Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and added tests for node reload_secure_settings and usage APIs. #694

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 25, 2024

Description

  • Fixed response from /_nodes/.../reload_secure_settings.
  • Fixed responses from /_nodes/.../usage.

Issues Resolved

Part of #663.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock changed the title Node apis Fixed and added tests for node reload_secure_settings and usage APIs. Nov 25, 2024
Signed-off-by: dblock <dblock@amazon.com>
Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
528 393 (74.43 %)

Signed-off-by: dblock <dblock@amazon.com>
Copy link
Contributor

Changes Analysis

Commit SHA: bcc099c
Comparing To SHA: 4615564

API Changes

Summary

└─┬Components
  ├──[➕] schemas (53814:7)
  ├─┬nodes.usage___Metric
  │ └──[➕] enum (55221:11)
  ├─┬nodes.usage___NodeUsage
  │ ├──[➖] required (55233:11)❌ 
  │ └──[➖] required (55234:11)❌ 
  ├─┬nodes._common___NodeReloadResult
  │ ├──[➕] anyOf (53807:7)
  │ ├──[➕] anyOf (53814:7)
  │ ├──[➖] oneOf (53807:7)❌ 
  │ └──[➖] oneOf (54244:7)❌ 
  └─┬nodes._common___NodeReloadError
    ├──[➖] required (53814:11)❌ 
    ├──[➖] type (53807:13)❌ 
    ├──[➖] properties (53809:9)❌ 
    ├──[➖] properties (53811:9)❌ 
    ├──[➕] allOf (53814:7)
    └──[➕] allOf (53809:11)

Document Element Total Changes Breaking Changes
components 14 8
  • BREAKING Changes: 8 out of 14
  • Removals: 8
  • Additions: 6
  • Breaking Removals: 8

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12014616804/artifacts/2234174679

API Coverage

Before After Δ
Covered (%) 599 (58.67 %) 599 (58.67 %) 0 (0 %)
Uncovered (%) 422 (41.33 %) 422 (41.33 %) 0 (0 %)
Unknown 42 42 0

@nhtruong nhtruong merged commit 9323eec into opensearch-project:main Nov 26, 2024
27 checks passed
@dblock dblock deleted the node-apis branch November 26, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants