Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce sample search quality dashboards and supporting data #219

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

epugh
Copy link

@epugh epugh commented Dec 4, 2024

Description

Introduces new Search Quality dashboards.

This is part one of two. The second part will be some new sample UBI Dashboards.

Issues Resolved

Partly addresses #214

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
@epugh
Copy link
Author

epugh commented Dec 4, 2024

@gaiksaya when we chatted, I think you pointed me to where I need to add the install script. The original script I used is here, https://github.com/opensearch-project/user-behavior-insights/blob/main/search-quality-evaluation-dashboards/install_dashboards.sh.

Can you remind me how to load the data as part of the nightly?

Once this is in, I'll also open a PR for the UBI dashboards! Under the sample sample-data directory.

@epugh
Copy link
Author

epugh commented Dec 4, 2024

not quite sure how to integrate and test the loading script... Something like?

curl -X POST -f 'https://${{needs.validate-and-deploy.outputs.ENDPOINT}}/${{needs.validate-and-deploy.outputs.PLAYGROUND_ID}}/sqe_metrics_sample_data/_bulk?pretty=false&filter_path=-items"' -H 'securitytenant: global' -H 'Content-Type: application/json' -H 'osd-version: ${{inputs.dist_version}}' -H 'osd-xsrf: osd-fetch' -u ${{ secrets.OPENSEARCH_USER }}:${{ secrets.OPENSEARCH_PASSWORD }} --insecure --data-binary @./nightly-playground/sample-data/search-quality-evaluation-dashboards/sample_search_quality_evaluation_data.ndjson

@gaiksaya
Copy link
Member

gaiksaya commented Dec 4, 2024

not quite sure how to integrate and test the loading script... Something like?

curl -X POST -f 'https://${{needs.validate-and-deploy.outputs.ENDPOINT}}/${{needs.validate-and-deploy.outputs.PLAYGROUND_ID}}/sqe_metrics_sample_data/_bulk?pretty=false&filter_path=-items"' -H 'securitytenant: global' -H 'Content-Type: application/json' -H 'osd-version: ${{inputs.dist_version}}' -H 'osd-xsrf: osd-fetch' -u ${{ secrets.OPENSEARCH_USER }}:${{ secrets.OPENSEARCH_PASSWORD }} --insecure --data-binary @./nightly-playground/sample-data/search-quality-evaluation-dashboards/sample_search_quality_evaluation_data.ndjson

Right. We are doing something similar here: https://github.com/opensearch-project/opensearch-devops/blob/main/.github/workflows/nightly-playground-deploy.yml#L140-L144
We can add this to same block.

Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
@epugh epugh marked this pull request as ready for review December 10, 2024 14:09
@epugh
Copy link
Author

epugh commented Dec 10, 2024

@gaiksaya I just added the two curl commands similar to the ones you linked. I don't have any way to test this (should I be able to run it locally???). I'd love to get a pairing session with you today or tomorrow if possible. We have a demo on Thursday and I'd love to be able to show this off!

@gaiksaya
Copy link
Member

@gaiksaya I just added the two curl commands similar to the ones you linked. I don't have any way to test this (should I be able to run it locally???). I'd love to get a pairing session with you today or tomorrow if possible. We have a demo on Thursday and I'd love to be able to show this off!

Hi @epugh
Sorry was out of office for a week. I tried running command and received 404. I believe we need to create the index sqe_metrics_sample_data first right?

@epugh
Copy link
Author

epugh commented Dec 16, 2024

@gaiksaya I just added the two curl commands similar to the ones you linked. I don't have any way to test this (should I be able to run it locally???). I'd love to get a pairing session with you today or tomorrow if possible. We have a demo on Thursday and I'd love to be able to show this off!

Hi @epugh Sorry was out of office for a week. I tried running command and received 404. I believe we need to create the index sqe_metrics_sample_data first right?

You are correct. For some reason I thought we created it "on the fly"... Let me tweak the PR and have something for you tomorrow with that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📦 Backlog
Development

Successfully merging this pull request may close these issues.

2 participants