Add the Total fields to the SearchResp struct #635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsadow
requested review from
dblock,
VijayanB,
VachaShah and
Jakob3xD
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
===========================================
- Coverage 57.29% 15.48% -41.81%
===========================================
Files 315 316 +1
Lines 9823 7756 -2067
===========================================
- Hits 5628 1201 -4427
- Misses 2902 6473 +3571
+ Partials 1293 82 -1211
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: rjsadow <richard.j.sadowski@gmail.com>
rjsadow
force-pushed
the
search-resp-total
branch
from
5580651 to
375d0c6
Compare
|
Did you mean to close this? Is this incorrect? |
|
I did mean to close it. I was incorrect and the SDK already handles this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The opensearch Search reference documentation give some information on the
track_total_hitsparameter but doesn't include the full response body when it's used.track_total_hitsis useful when you're trying to get a count of all hits in a given index for a given query without using the scroll api or some other traching mechinism.This PR adds the return values structure for the
track_total_hitsparameter into the SearchResp structure.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.