Query grouping dashboard changes and extensive tests #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9efdbaf. Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
deshsidd
requested review from
ansjcy,
jainankitk and
dzane17
as code owners
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
ansjcy
reviewed
Dec 23, 2024
| import QueryGroupAggregateSummary from "./Components/QueryGroupAggregateSummary"; | ||
| import QueryGroupSampleQuerySummary from "./Components/QueryGroupSampleQuerySummary"; | ||
|
|
||
| const QueryGroupDetails = ({ queries, core }: { queries: any; core: CoreStart }) => { |
There was a problem hiding this comment.
Why do we need this new component? Is it possible to reuse the QueryDetails page? Cause I see a lot of duplicate logic here with QueryDetails.tsx
| render: (query: any) => { | ||
| return ( | ||
| <span> | ||
| <EuiLink onClick={() => { |
There was a problem hiding this comment.
are we having 2 same links points to the query group details?
| const route = query.group_by === 'SIMILARITY' ? `/query-group-details/${hash(query)}` : `/query-details/${hash(query)}`; | ||
| history.push(route); | ||
| }}> | ||
| {query.query_hashcode || '-'} |
There was a problem hiding this comment.
We should probably use query_id for this if displaying single query: opensearch-project/query-insights#159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Query grouping dashboard changes based on the proposed UX. Support grouping related configurations setting and viewing query groups using the query insights dashboards.
Currently, dashboards only supports Top N queries. With the introduction of grouping Top N queries by similarity, this PR aims to integrate query insights dashboard with the query grouping changes.
Change Details:
typeto filter outgroupsorqueriesIssues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Closes : #14
Screenshots
Top N queries/groups page displaying multiple query groups:
Option to filter by group/query:
Query Group Details Page after clicking on the query group row in the Top N page:
Sample Query Details section on the query group details page:
Query Configuration Page to configure Top N Query Groups:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.