-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing index permission #2031
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2031 +/- ##
=======================================
Coverage 71.39% 71.39%
=======================================
Files 97 97
Lines 2650 2650
Branches 410 403 -7
=======================================
Hits 1892 1892
Misses 642 642
Partials 116 116 ☔ View full report in Codecov by Sentry. |
Adding plugin permissions to this dropdown can cause unexpected experiences when trying to use functionality from plugins. Generally, its recommended for plugin developers to create pre-defined roles where they can provide assurances that those roles will allow a mapped user the ability to use a plugin in an expected way. I'm not opposed to adding individual plugin permissions to this dropdown, but I think it should be coupled with inline link to documentation for what APIs the action allows a mapped user to perform. |
Description
Adds missing index permission indices:admin/opensearch/ism/managedindex
Category
Bug fix
Why these changes are required?
Fix issue: opensearch-project/security#4559
What is the old behavior before changes and new behavior after changes?
The permission will show up in the dropdown.
Issues Resolved
Fix: opensearch-project/security#4559
Testing
Manual testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.