Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing index permission #2031

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Jul 15, 2024

Description

Adds missing index permission indices:admin/opensearch/ism/managedindex

Category

Bug fix

Why these changes are required?

Fix issue: opensearch-project/security#4559

What is the old behavior before changes and new behavior after changes?

The permission will show up in the dropdown.

Issues Resolved

Fix: opensearch-project/security#4559

Testing

Manual testing

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho marked this pull request as ready for review July 15, 2024 19:44
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.39%. Comparing base (b1148fb) to head (a60ba1c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2031   +/-   ##
=======================================
  Coverage   71.39%   71.39%           
=======================================
  Files          97       97           
  Lines        2650     2650           
  Branches      410      403    -7     
=======================================
  Hits         1892     1892           
  Misses        642      642           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks
Copy link
Member

cwperks commented Jul 16, 2024

Adding plugin permissions to this dropdown can cause unexpected experiences when trying to use functionality from plugins.

Generally, its recommended for plugin developers to create pre-defined roles where they can provide assurances that those roles will allow a mapped user the ability to use a plugin in an expected way.

I'm not opposed to adding individual plugin permissions to this dropdown, but I think it should be coupled with inline link to documentation for what APIs the action allows a mapped user to perform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Policy is not being applied to new indices due to indices:admin/opensearch/ism/managedindex
6 participants