Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Spring Boot externalized configuration #1199

Merged

Conversation

edeandrea
Copy link
Contributor

Part of #1060

@edeandrea edeandrea marked this pull request as ready for review June 21, 2021 17:46
@edeandrea edeandrea force-pushed the sb-update-external-config branch from 0d39a1e to d872fd4 Compare June 21, 2021 17:48
@edeandrea
Copy link
Contributor Author

@jamesfalkner I'm not sure why its saying assets/middleware/rhoar-microservices/editconfigmap.png is removed - I updated the image but did not remove it.

@edeandrea edeandrea mentioned this pull request Jun 21, 2021
45 tasks
@jdob
Copy link

jdob commented Jun 21, 2021

This will also fix #418

@edeandrea
Copy link
Contributor Author

Fixes #418

@edeandrea
Copy link
Contributor Author

This needs to be merged together with openshift-instruqt/rhoar-getting-started#70 since that PR has the code changes which go along with the guide changes in this PR.

@jamesfalkner jamesfalkner merged commit 2dc41bf into openshift-labs:master Jun 21, 2021
@edeandrea edeandrea deleted the sb-update-external-config branch July 8, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants