Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.1.379 #856

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Release v0.1.379 #856

merged 1 commit into from
Oct 31, 2023

Conversation

machi1990
Copy link
Contributor

Depends on #855

@machi1990 machi1990 mentioned this pull request Oct 23, 2023
Merged
@miguelsorianod
Copy link
Contributor

miguelsorianod commented Oct 23, 2023 •
edited
Loading

lgtm. I understand it is only the change in the changelog and version number. The other changes are just the changes of #855 which this MR is built upon

@machi1990
Copy link
Contributor Author

lgtm. I understand it is only the change in the changelog and version number. The other changes are just the changes of #855 which this MR is built upon

Thanks correct. The relevant change for this PR is the changelog and version number. The rest are brought over by the #855. I'll rebase once the other PR is in and mark this PR for review.

@machi1990 machi1990 force-pushed the release/v.1.377 branch 2 times, most recently from d8d527b to 69a5994 Compare October 31, 2023 10:42
@machi1990 machi1990 marked this pull request as ready for review October 31, 2023 10:43
@machi1990 machi1990 changed the title Release v0.1.377 Release v0.1.379 Oct 31, 2023
@machi1990
Copy link
Contributor Author

@tzvatot @zgalor PTAL - this is to release the changes on #855

@zgalor
Copy link
Collaborator

zgalor commented Oct 31, 2023 •
edited
Loading

@machi1990 where is the actual version change PR?

https://github.com/openshift-online/ocm-sdk-go/blob/main/version.go#L21

@machi1990
Copy link
Contributor Author

@machi1990 where is the actual version change PR?

https://github.com/openshift-online/ocm-sdk-go/blob/main/version.go#L21

Good catch @zgalor thanks!

I forgot to bump it once again after rebasing.

zgalor
zgalor approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@zgalor zgalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zgalor zgalor merged commit 49961c3 into openshift-online:main Oct 31, 2023
3 checks passed
@machi1990
Copy link
Contributor Author

Thanks @zgalor

@machi1990 machi1990 deleted the release/v.1.377 branch October 31, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zgalor zgalor zgalor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@machi1990 @miguelsorianod @zgalor