Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-5281 | Feat | Add regions support from ocm shards #882

Merged
merged 8 commits into from
Jan 31, 2024

Conversation

tirthct
Copy link
Contributor

@tirthct tirthct commented Dec 18, 2023

Changed

  • Add regions support from ocm shards

Tested
-Regions should return correct value for endpoints : tested

@tirthct tirthct marked this pull request as draft December 18, 2023 20:36
rh_region.go Outdated Show resolved Hide resolved
rh_region.go Outdated Show resolved Hide resolved
@tirthct tirthct marked this pull request as ready for review January 30, 2024 19:16
@macgregor
Copy link

lgtm, thanks @tirthct

Copy link
Collaborator

@markturansky markturansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markturansky markturansky merged commit 488416a into openshift-online:main Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants