Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-4961 | Feat | Add authentication using OAuth2 and PCKE #885

Merged
merged 10 commits into from
Jan 17, 2024
Merged

OCM-4961 | Feat | Add authentication using OAuth2 and PCKE #885

merged 10 commits into from
Jan 17, 2024

Conversation

tirthct
Copy link
Contributor

@tirthct tirthct commented Jan 9, 2024

Changed

  • Add auth.go that uses OAuth2 and PCKE for getting access token
  • Add example to verify authentication

Tested

  • Auth should redirect to Red Hat SSO and get access token from there : tested

@tirthct tirthct requested a review from tylercreller January 9, 2024 00:37
tirthct
tirthct commented Jan 9, 2024
View reviewed changes
authentication/auth.go Outdated Show resolved Hide resolved
tirthct
tirthct commented Jan 9, 2024
View reviewed changes
authentication/auth.go Outdated Show resolved Hide resolved
@tirthct tirthct changed the title Add authentication using OAuth2 and PCKE OCM-4961 | Feat | Add authentication using OAuth2 and PCKE Jan 9, 2024
tylercreller
tylercreller reviewed Jan 9, 2024
View reviewed changes
authentication/auth.go Outdated Show resolved Hide resolved
authentication/auth.go Show resolved Hide resolved
authentication/auth.go Outdated Show resolved Hide resolved
@tylercreller tylercreller requested a review from vkareh January 10, 2024 20:40
@tirthct tirthct mentioned this pull request Jan 12, 2024
Merged
@tylercreller
Copy link
Member

LGTM once prod SSO is ready to go

@tirthct tirthct marked this pull request as ready for review January 16, 2024 16:08
@tylercreller tylercreller merged commit e288e55 into openshift-online:main Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylercreller tylercreller tylercreller approved these changes

@vkareh vkareh Awaiting requested review from vkareh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tirthct @tylercreller