OCM-4965: Secure store tweaks #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tylercreller
commented
Feb 13, 2024
tylercreller
commented
- Add test for invalid and empty keyrings
- Additional Error Standardization
- Add support that allows the caller to define a keyring to target
- Add error handling for denied Keychain access due to permissions
tirthct
approved these changes
Feb 13, 2024
macgregor
reviewed
Feb 14, 2024
| } | ||
|
|
||
| if strings.Contains(err.Error(), "Keychain Error. (-25244)") { | ||
| return fmt.Errorf("%s\nThis application may not have permission to delete from the Keychain. Please check the permissions in the Keychain and try again", err.Error()) |
There was a problem hiding this comment.
Friendly reminder that when wrapping errors your should use "%w" rather than %s or %v to properly preserve the original error (which potentially includes a stack trace) in case callers want it: https://gosamples.dev/wrap-unwrap-errors/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.