Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]auto capi cases #339

Closed
wants to merge 1 commit into from
Closed

[WIP]auto capi cases #339

wants to merge 1 commit into from

Conversation

huali9
Copy link
Contributor

@huali9 huali9 commented Nov 7, 2024

write two capi cases for AWS, run in local passed.

liuhuali@Lius-MacBook-Pro cluster-api-actuator-pkg % ./hack/ci-integration.sh -focus "Cluster API AWS MachineSet" -v
Running Suite: Machine Suite - /Users/liuhuali/project/cluster-api-actuator-pkg/pkg
===================================================================================
Random Seed: 1730964939

Will run 2 of 41 specs
------------------------------
[BeforeSuite] 
/Users/liuhuali/project/cluster-api-actuator-pkg/pkg/e2e_test.go:48
[BeforeSuite] PASSED [1.633 seconds]
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
Cluster API AWS MachineSet should be able to run a machine with a default provider spec
/Users/liuhuali/project/cluster-api-actuator-pkg/pkg/capi/aws.go:88
  STEP: Creating core cluster @ 11/07/24 15:35:57.845
  STEP: Creating AWS machine template @ 11/07/24 15:35:58.723
  STEP: Creating MachineSet "aws-machineset" @ 11/07/24 15:35:59.294
  STEP: Waiting for MachineSet machines "aws-machineset" to enter Running phase @ 11/07/24 15:35:59.586
  STEP: Deleting MachineSet "aws-machineset" @ 11/07/24 15:39:40.639
  STEP: Waiting for MachineSet "aws-machineset" to be deleted @ 11/07/24 15:39:40.929
  STEP: Deleting /aws-machine-template @ 11/07/24 15:41:43.546
• [347.198 seconds]
------------------------------
Cluster API AWS MachineSet should be able to run a machine with cluster placement group
/Users/liuhuali/project/cluster-api-actuator-pkg/pkg/capi/aws.go:97
  STEP: Creating AWS machine template @ 11/07/24 15:41:43.832
  STEP: Creating MachineSet "aws-machineset" @ 11/07/24 15:41:44.125
  STEP: Waiting for MachineSet machines "aws-machineset" to enter Running phase @ 11/07/24 15:41:44.416
  STEP: Deleting MachineSet "aws-machineset" @ 11/07/24 15:45:25.205
  STEP: Waiting for MachineSet "aws-machineset" to be deleted @ 11/07/24 15:45:25.493
  STEP: Deleting /aws-machine-template @ 11/07/24 15:47:28.665
• [345.176 seconds]
------------------------------
SSSSSSSSSSSS
------------------------------
[ReportAfterSuite] Autogenerated ReportAfterSuite for --junit-report
autogenerated by Ginkgo
[ReportAfterSuite] PASSED [0.004 seconds]
------------------------------

Ran 2 of 41 Specs in 694.009 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 39 Skipped
PASS

Ginkgo ran 1 suite in 11m49.482590422s
Test Suite Passed

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@openshift-ci openshift-ci bot requested review from nrb and RadekManak November 7, 2024 09:09
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@huali9
Copy link
Contributor Author

huali9 commented Nov 7, 2024

@sunzhaohua2 @miyadav @shellyyang1989 I think this is the benefit of using interfaces, it's simple to write CAPI cases for each field.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2024
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

@huali9: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint bbb47ba link true /test lint
ci/prow/e2e-aws-capi-techpreview bbb47ba link true /test e2e-aws-capi-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@huali9
Copy link
Contributor Author

huali9 commented Nov 21, 2024

Raised a new pr #342, so this pr is not needed now.
/close

Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@huali9: Closed this PR.

In response to this:

Raised a new pr #342, so this pr is not needed now.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants