-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPQE-26161,OCPBUGS-46552: Update labels to distinguish different tests #344
Conversation
@sunzhaohua2: This pull request references OCPQE-26161 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6923fff
to
1e45b5e
Compare
@sunzhaohua2: This pull request references OCPQE-26161 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
LabelMachineApprover = ginkgo.Label("machine-approver") | ||
LabelCCM = ginkgo.Label("ccm") | ||
LabelDisruptive = ginkgo.Label("disruptive") | ||
LabelPeriodic = ginkgo.Label("periodic") | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit pick - can we arrange alphabetically for easy read -
`LabelAutoscaler = ginkgo.Label("autoscaler")
LabelCAPI = ginkgo.Label("capi")
LabelCCM = ginkgo.Label("ccm")
LabelDevOnly = ginkgo.Label("dev-only")
LabelDisruptive = ginkgo.Label("disruptive")
LabelLEVEL0 = ginkgo.Label("LEVEL0")
LabelMAPI = ginkgo.Label("mapi")
LabelMachineApprover = ginkgo.Label("machine-approver")
LabelMachineHealthChecks = ginkgo.Label("machine-health-checks")
LabelPeriodic = ginkgo.Label("periodic")
LabelQEOnly = ginkgo.Label("qe-only")
`
pkg/framework/ginkgo-labels.go
Outdated
LabelAutoscaler = ginkgo.Label("autoscaler") | ||
LabelCAPI = ginkgo.Label("capi") | ||
LabelMAPI = ginkgo.Label("mapi") | ||
LabelMachineHealthChecks = ginkgo.Label("machine-health-checks") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, probably just machine-health-check
, I think that would be consistent
pkg/framework/ginkgo-labels.go
Outdated
LabelMachineHealthChecks = ginkgo.Label("machine-health-checks") | ||
LabelCloudProviderSpecific = ginkgo.Label("cloud-provider-specific") | ||
LabelProviderAWS = ginkgo.Label("AWS") | ||
LabelQEOnly = ginkgo.Label("qe-only") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get a godoc on each field to show what each means. Most are fairly self explanatory but level0 for example, is not
1e45b5e
to
9b7ea17
Compare
9b7ea17
to
eac728c
Compare
LGTM |
@sunzhaohua2: This pull request references OCPQE-26161 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. This pull request references Jira Issue OCPBUGS-46552, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sunzhaohua2. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sunzhaohua2: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
b5124a3
into
openshift:master
@sunzhaohua2: Jira Issue OCPBUGS-46552: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-46552 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Update labels based on doc
LEVEL0&&!qe-only
as now only few LEVEL0 cases, and we have a total of 41 cases in repo, so I think keep the status quo is ok, in future we have more cases, then we change it to run only LEVEL0. If you think it's better to change to LEVEL0, I'm also ok with that.@JoelSpeed @shellyyang1989 @huali9 @miyadav PTAL