Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPQE-26161,OCPBUGS-46552: Update labels to distinguish different tests #344

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

sunzhaohua2
Copy link
Contributor

@sunzhaohua2 sunzhaohua2 commented Nov 26, 2024

Update labels based on doc

  • QE run test in 2 jobs, one is non-disruptive, one is disruptive, so added disruptive labels to some cases to make sure these cases are not run in parallel.
  • In order to select feature related cases in different repos, added capi/mapi/autoscaler/machine-health-checks/machine-approver/ccm labels.
  • Added qe-only/dev-only label to make sure some cases can only run in qe or dev account.
  • I didn't update Makefile to LEVEL0&&!qe-only as now only few LEVEL0 cases, and we have a total of 41 cases in repo, so I think keep the status quo is ok, in future we have more cases, then we change it to run only LEVEL0. If you think it's better to change to LEVEL0, I'm also ok with that.

@JoelSpeed @shellyyang1989 @huali9 @miyadav PTAL

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024

@sunzhaohua2: This pull request references OCPQE-26161 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • The qe job mainly selects cases to execute based on whether the case is disruptive, so added disruptive labels to some cases.
  • In order to distinguish between capi cases and mapi cases, I changed LabelMachines to LabelMAPI.
  • Add LabelMachineApprover to select cases to execute based on labels in the rebase regression jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 17, 2024

@sunzhaohua2: This pull request references OCPQE-26161 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Update labels based on doc

  • QE run test in 2 jobs, one is non-disruptive, one is disruptive, so added disruptive labels to some cases to make sure these cases are not run in parallel.
  • In order to select feature related cases in different repos, added capi/mapi/autoscaler/machine-health-checks/machine-approver/ccm labels.
  • Added qe-only/dev-only label to make sure some cases can only run in qe or dev account.
  • I didn't update Makefile to LEVEL0&&!qe-only as now only few LEVEL0 cases, and we have a total of 41 cases in repo, so I think keep the status quo is ok, in future we have more cases, then we change it to run only LEVEL0. If you think it's better to change to LEVEL0, I'm also ok with that.

@JoelSpeed @shellyyang1989 @huali9 @miyadav PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

LabelMachineApprover = ginkgo.Label("machine-approver")
LabelCCM = ginkgo.Label("ccm")
LabelDisruptive = ginkgo.Label("disruptive")
LabelPeriodic = ginkgo.Label("periodic")
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick - can we arrange alphabetically for easy read -

`LabelAutoscaler          = ginkgo.Label("autoscaler")
LabelCAPI                = ginkgo.Label("capi")
LabelCCM                 = ginkgo.Label("ccm")
LabelDevOnly             = ginkgo.Label("dev-only")
LabelDisruptive          = ginkgo.Label("disruptive")
LabelLEVEL0              = ginkgo.Label("LEVEL0")
LabelMAPI                = ginkgo.Label("mapi")
LabelMachineApprover     = ginkgo.Label("machine-approver")
LabelMachineHealthChecks = ginkgo.Label("machine-health-checks")
LabelPeriodic            = ginkgo.Label("periodic")
LabelQEOnly              = ginkgo.Label("qe-only")
`

LabelAutoscaler = ginkgo.Label("autoscaler")
LabelCAPI = ginkgo.Label("capi")
LabelMAPI = ginkgo.Label("mapi")
LabelMachineHealthChecks = ginkgo.Label("machine-health-checks")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, probably just machine-health-check, I think that would be consistent

LabelMachineHealthChecks = ginkgo.Label("machine-health-checks")
LabelCloudProviderSpecific = ginkgo.Label("cloud-provider-specific")
LabelProviderAWS = ginkgo.Label("AWS")
LabelQEOnly = ginkgo.Label("qe-only")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a godoc on each field to show what each means. Most are fairly self explanatory but level0 for example, is not

@huali9
Copy link
Contributor

huali9 commented Dec 18, 2024

LGTM
Thank you Zhaohua!

@sunzhaohua2 sunzhaohua2 changed the title OCPQE-26161: Update labels to distinguish different tests OCPQE-26161,OCPBUGS-46552: Update labels to distinguish different tests Dec 18, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 18, 2024

@sunzhaohua2: This pull request references OCPQE-26161 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

This pull request references Jira Issue OCPBUGS-46552, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update labels based on doc

  • QE run test in 2 jobs, one is non-disruptive, one is disruptive, so added disruptive labels to some cases to make sure these cases are not run in parallel.
  • In order to select feature related cases in different repos, added capi/mapi/autoscaler/machine-health-checks/machine-approver/ccm labels.
  • Added qe-only/dev-only label to make sure some cases can only run in qe or dev account.
  • I didn't update Makefile to LEVEL0&&!qe-only as now only few LEVEL0 cases, and we have a total of 41 cases in repo, so I think keep the status quo is ok, in future we have more cases, then we change it to run only LEVEL0. If you think it's better to change to LEVEL0, I'm also ok with that.

@JoelSpeed @shellyyang1989 @huali9 @miyadav PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sunzhaohua2.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sunzhaohua2: This pull request references OCPQE-26161 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

This pull request references Jira Issue OCPBUGS-46552, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update labels based on doc

  • QE run test in 2 jobs, one is non-disruptive, one is disruptive, so added disruptive labels to some cases to make sure these cases are not run in parallel.
  • In order to select feature related cases in different repos, added capi/mapi/autoscaler/machine-health-checks/machine-approver/ccm labels.
  • Added qe-only/dev-only label to make sure some cases can only run in qe or dev account.
  • I didn't update Makefile to LEVEL0&&!qe-only as now only few LEVEL0 cases, and we have a total of 41 cases in repo, so I think keep the status quo is ok, in future we have more cases, then we change it to run only LEVEL0. If you think it's better to change to LEVEL0, I'm also ok with that.

@JoelSpeed @shellyyang1989 @huali9 @miyadav PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 84b1711 and 2 for PR HEAD eac728c in total

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@sunzhaohua2: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-operator eac728c link false /test e2e-openstack-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b5124a3 into openshift:master Dec 18, 2024
8 of 9 checks passed
@openshift-ci-robot
Copy link

@sunzhaohua2: Jira Issue OCPBUGS-46552: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-46552 has been moved to the MODIFIED state.

In response to this:

Update labels based on doc

  • QE run test in 2 jobs, one is non-disruptive, one is disruptive, so added disruptive labels to some cases to make sure these cases are not run in parallel.
  • In order to select feature related cases in different repos, added capi/mapi/autoscaler/machine-health-checks/machine-approver/ccm labels.
  • Added qe-only/dev-only label to make sure some cases can only run in qe or dev account.
  • I didn't update Makefile to LEVEL0&&!qe-only as now only few LEVEL0 cases, and we have a total of 41 cases in repo, so I think keep the status quo is ok, in future we have more cases, then we change it to run only LEVEL0. If you think it's better to change to LEVEL0, I'm also ok with that.

@JoelSpeed @shellyyang1989 @huali9 @miyadav PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants