Fix failed token deletion

[rev3r4nt]

Randomly, the openshift_auth module exits in error and does not delete the token.

Couldn't delete user oauth access token 'sha256~BmhQbi0TLPGJqA15PdLbbfJesJlQX_208Iv9saVpU2U' due to: useroauthaccesstokens.oauth.openshift.io \"sha256~BmhQbi0TLPGJqA15PdLbbfJesJlQX_208Iv9saVpU2U\" not found

When this happens, the token name does not match the one returned by the Openshift API.

$ oc get useroauthaccesstokens
NAME                                                 CLIENT NAME
sha256~CZMJTLYVJAyDWZ4JvOrE48J97xpn0HIstFSDT3yHyWM   openshift-challenging-client

Ansible version: core 2.15.3
Python version: 3.10.8
Collection community.okd version 2.3.0

I discovered that it failed because Python strip method argument is not a prefix or suffix; rather, all combinations of its values are stripped. So if the token begins with a character of the set sha256~, the token name is not correctly deducted.

[openshift-ci]

Hi @rev3r4nt. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gravesm]

We should only slice if the string starts with the prefix:

if token_name.startswith(sha256Prefix):
    content = token_name[len(sha256Prefix):]
else:
    content = token_name

[gravesm]

/ok-to-test

[rev3r4nt]

/retest

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[gravesm]

/remove-lifecycle rotten

[HaleCT2]

Would love to see this fixed - Using this module with AAP/ACM, it's frustrating having an Automation Template Job fail at the "logout" task randomly

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[HaleCT2]

/remove-lifecycle stale

[seanmalloy]

/retest

[seanmalloy]

@rev3r4nt I see the CI automation failed previously. I've re-triggered the failing tests. Are you still interested in having this change merged?

[seanmalloy]

@gravesm and @alinabuzachis the two required CI checks are now passing. Would you have time to review? Is there anything else needed?

/assign @gravesm @alinabuzachis

[openshift-ci]

@seanmalloy: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@seanmalloy: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rev3r4nt, seanmalloy
Once this PR has been reviewed and has the lgtm label, please ask for approval from alinabuzachis. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@rev3r4nt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[seanmalloy]

@gravesm and @alinabuzachis is there anything else needed before this can be merged?

[gravesm]

@seanmalloy The sanity checks need to pass, but I haven't had time to look into why they're failing. It's likely nothing to do with this PR and is probably some config issue with CI. Will try to get to it as soon as I can.

[alinabuzachis]

@seanmalloy Can you please fix the indentation?

ERROR: Found 2 pep8 issue(s) which need to be resolved:
--
970 | 2024-06-24 18:20:05.525014 \| controller \| ERROR: plugins/modules/openshift_auth.py:228:7: E111: indentation is not a multiple of 4
971 | 2024-06-24 18:20:05.525054 \| controller \| ERROR: plugins/modules/openshift_auth.py:230:7: E111: indentation is not a multiple of 4