Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2758: Bump webpack-cli and webpack-dev-server to latest version #8269

Merged
merged 1 commit into from
Mar 6, 2021
Merged

CONSOLE-2758: Bump webpack-cli and webpack-dev-server to latest version #8269

merged 1 commit into from
Mar 6, 2021

Conversation

vojtechszocs
Copy link
Contributor

  • webpack-cli bumped from 3.3.9 to 4.5.0
  • webpack-dev-server bumped from 3.11.0 to 3.11.1
  • add matching @types/webpack-dev-server dev-dependency

The dev script has been updated to invoke webpack-dev-server via webpack CLI.

Starting with webpack-cli v4, this is the standard way to run the dev-server. See here for details.

webpack serve --mode=development --progress

The analyze script has been updated to match changes in webpack-cli v4. See here for details.

Our main yarn.lock file contains some resolutions pointing to https://registry.npmjs.org/ instead of the expected https://registry.yarnpkg.com/ and found this Yarn issue which is fixed in Yarn v2 only.

@openshift-ci-robot openshift-ci-robot added the component/sdk Related to console-plugin-sdk label Mar 1, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
@vojtechszocs
Copy link
Contributor Author

cc @spadgett @christianvogt

@vojtechszocs vojtechszocs mentioned this pull request Mar 1, 2021
Merged
@spadgett spadgett changed the title Bump webpack-cli and webpack-dev-server to latest version CONSOLE-2758: Bump webpack-cli and webpack-dev-server to latest version Mar 1, 2021
@vojtechszocs
Copy link
Contributor Author

Right now, latest webpack-dev-server is 3.11.2 and latest @types/webpack-dev-server is 3.11.1 - I've opted to bump both to 3.11.1 for sake of consistency.

spadgett
spadgett approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@spadgett
Copy link
Member

spadgett commented Mar 1, 2021

Since this is a dev-only dependency, this does not need QE review.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

zherman0
zherman0 approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@zherman0 zherman0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will complete the other bump PRs once this merges

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, vojtechszocs, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Mar 3, 2021

Holding until #8289 merges to unblock CI.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2021
@spadgett
Copy link
Member

spadgett commented Mar 5, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1255e86 into openshift:master Mar 6, 2021
@spadgett spadgett added this to the v4.8 milestone Mar 18, 2021
spadgett added a commit to spadgett/release that referenced this pull request Mar 18, 2021
@spadgett
console: Don't use v22 builder image for 4.7
f99a78f 
The webpack-cli upgrade in

openshift/console#8269

was only made in 4.8. The analyze job will fail in 4.7 due to the older
webpack-cli version, so we should remain on v21 for 4.7.
@spadgett spadgett mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zherman0 zherman0 zherman0 approved these changes

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/sdk Related to console-plugin-sdk lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.
6 participants
@vojtechszocs @spadgett @openshift-bot @openshift-ci-robot @zherman0 @openshift-merge-robot