Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KFLUXUI-125): allow sorting pipeline runs by status and type #1020

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcin-michal
Copy link
Contributor

Fixes

https://issues.redhat.com/browse/KFLUXUI-125

Description

Before, in the application's activity tab, it was only possible to sort pipeline runs by status, and in the snapshot's pipeline runs by type. Now, it's possible to sort by both of these attributes in either of the page, making it more consistent.

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

image
image
image

How to test or reproduce?

Go to the activity tab for any application and view the pipeline runs. To view the snapshots pipeline runs, click on any pipeline run from the previous page, click on the snapshot and select the pipeline runs tab.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@marcin-michal
Copy link
Contributor Author

Right now, it's possible to select multiple statuses/types of a pipeline run in the filters. Is that fine or should it only allow to select one of each?

Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marcin-michal
Once this PR has been reviewed and has the lgtm label, please assign caugello for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (7e50952) to head (abcd662).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
+ Coverage   85.44%   85.59%   +0.15%     
==========================================
  Files         583      583              
  Lines       14420    14477      +57     
  Branches     4041     4061      +20     
==========================================
+ Hits        12321    12392      +71     
+ Misses       1972     1958      -14     
  Partials      127      127              
Files with missing lines Coverage Δ
...nents/PipelineRunListView/PipelineRunsListView.tsx 99.24% <100.00%> (+6.86%) ⬆️
.../SnapshotDetails/tabs/SnapshotPipelineRunsList.tsx 95.76% <100.00%> (+9.24%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e50952...abcd662. Read the comment docs.

---- 🚨 Try these New Features:

@marcin-michal
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2024
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

@marcin-michal: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@StanislavJochman
Copy link

lgtm

@StanislavJochman
Copy link

but it will need to be backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants