-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KFLUXUI-125): allow sorting pipeline runs by status and type #1020
base: main
Are you sure you want to change the base?
Conversation
Right now, it's possible to select multiple statuses/types of a pipeline run in the filters. Is that fine or should it only allow to select one of each? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marcin-michal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
==========================================
+ Coverage 85.44% 85.59% +0.15%
==========================================
Files 583 583
Lines 14420 14477 +57
Branches 4041 4061 +20
==========================================
+ Hits 12321 12392 +71
+ Misses 1972 1958 -14
Partials 127 127
Continue to review full report in Codecov by Sentry.
|
a9ad41f
to
0a8d8c8
Compare
/retest |
0a8d8c8
to
abcd662
Compare
@marcin-michal: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
lgtm |
but it will need to be backported |
Fixes
https://issues.redhat.com/browse/KFLUXUI-125
Description
Before, in the application's activity tab, it was only possible to sort pipeline runs by status, and in the snapshot's pipeline runs by type. Now, it's possible to sort by both of these attributes in either of the page, making it more consistent.
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Go to the activity tab for any application and view the pipeline runs. To view the snapshots pipeline runs, click on any pipeline run from the previous page, click on the snapshot and select the pipeline runs tab.
Browser conformance: