feat(secrets): update secret modal

[abhinandan13jan]

Fixes

https://issues.redhat.com/browse/HAC-5834

Description

This is WIP. Need to add tests

Type of change

• Feature
• Bugfix
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abhinandan13jan
Once this PR has been reviewed and has the lgtm label, please assign rohitkrai03 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[CryptoRodeo]

I think the initialValues in src/components/Secrets/__tests___/SecretModal.spec.tsx and src/components/Secrets/__tests___/SecretTypeSelector.spec.tsx will need to be changed based on the type error I'm seeing:

// Before
const initialValues: SecretModalValues = {
  secretName: '',
  type: SecretTypeDropdownLabel.opaque,
  keyValues: [{ key: '', value: '', readOnlyKey: false }],
  existingSecrets: [],
};

// After
const initialValues: SecretModalValues = {
  secretName: '',
  type: SecretTypeDropdownLabel.opaque,
  opaque: {
    keyValues: [{ key: '', value: '', readOnlyKey: false }],
  },
  existingSecrets: [],
};

[CryptoRodeo]

I am seeing failing tests for src/components/Secrets/__tests___/SecretModal.spec.tsx:

should render validation message when user click on create button without filling the form
should call onSubmit handler with newly added secret

[abhinandan13jan]

/retest

[openshift-ci]

@abhinandan13jan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/test	bc524b3	link	true	/test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[testcara]

Hi, Abhi, could you help to improve the description of the PR if it's ready for review?

[caugello]

When creating a source secret. In the secret list view the displayed type is key/value is this expected ?

[abhinandan13jan]

/hold
Need to hold this till we migrate to new UI

[abhinandan13jan]

/retest test

[openshift-ci]

@abhinandan13jan: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

• /test images
• /test test

Use /test all to run all jobs.

In response to this:

/retest test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.