Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-36264: add Proxy config #28912

Merged
merged 5 commits into from
Aug 12, 2024
Merged

[release-4.15] OCPBUGS-36264: add Proxy config #28912

merged 5 commits into from
Aug 12, 2024

Conversation

LiangquanLi930
Copy link
Member

@LiangquanLi930 LiangquanLi930 commented Jun 27, 2024 •
edited
Loading

manual cherry-pick #28880

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 27, 2024
@openshift-ci-robot
Copy link

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is invalid:

  • expected Jira Issue OCPBUGS-36264 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is invalid:

  • expected Jira Issue OCPBUGS-36264 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from frobware and knobunc June 27, 2024 12:04
@LiangquanLi930
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 27, 2024
@openshift-ci-robot
Copy link

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-35842 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-35842 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: LiangquanLi930.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-35842 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-35842 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lihongan
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 28, 2024
@openshift-ci-robot
Copy link

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-35842 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-35842 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 28, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: LiangquanLi930.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-35842 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-35842 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@LiangquanLi930
Copy link
Member Author

/test e2e-gcp-ovn

@LiangquanLi930 LiangquanLi930 force-pushed the router-proxy-415-4 branch 3 times, most recently from d08c49d to e031364 Compare June 29, 2024 07:00
@LiangquanLi930
Copy link
Member Author

/retest

1 similar comment
@LiangquanLi930
Copy link
Member Author

/retest

@LiangquanLi930
Copy link
Member Author

@frobware Could you help review this PR? Thanks

@openshift-ci-robot
Copy link

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-35842 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-35842 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

manual cherry-pick #28880

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: LiangquanLi930.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-35842 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-35842 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

manual cherry-pick #28880

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@LiangquanLi930
Copy link
Member Author

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@LiangquanLi930: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Miciah
Miciah reviewed Jul 10, 2024
View reviewed changes
test/extended/router/http2.go Outdated
Comment on lines 48 to 51
Timeout: timeout,
Transport: &http.Transport{
TLSClientConfig: &tlsConfig,
Proxy: http.ProxyFromEnvironment,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This transport is overridden if useHTTP2Transport is true, so it seems like the test will still fail for the useHTTP2Transport: true test cases if using a proxy is required.

Would it make sense to backport #28540 too? This is the crucial change from #28540 to avoid overriding the transport that has the proxy configuration:

 	if useHTTP2Transport {
-		c.Transport = &http2.Transport{
-			TLSClientConfig: &tlsConfig,
-		}
+		// Explicitly allow HTTP/2.
+		http2.ConfigureTransport(transport)
 	}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Miciah are you available to review this? I thought we might have to expedite a change to the OWNERS file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a best effort. However, updating OWNERS shouldn't be blocking anyone from reviewing PRs; if someone else from the team has capacity to review, then that person can add an /lgtm and then ping me, Miheer, or knobunc to add a rubber-stamp /lgtm.

@LiangquanLi930
Copy link
Member Author

/retest

@knobunc
Copy link
Contributor

knobunc commented Jul 18, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, knobunc, LiangquanLi930

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@candita
Copy link
Contributor

candita commented Jul 18, 2024

/test e2e-metal-ipi-ovn-ipv6

@candita
Copy link
Contributor

candita commented Jul 19, 2024

Let's see if the bug found and fixed by @LiangquanLi930 is ready yet.
/test e2e-metal-ipi-ovn-ipv6

@LiangquanLi930
Copy link
Member Author

/retest

3 similar comments
@LiangquanLi930
Copy link
Member Author

/retest

@LiangquanLi930
Copy link
Member Author

/retest

@LiangquanLi930
Copy link
Member Author

/retest

@LiangquanLi930
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

3 similar comments
@LiangquanLi930
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

@LiangquanLi930
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

@LiangquanLi930
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 31, 2024 •
edited
Loading

@LiangquanLi930: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 920ee1b link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 920ee1b link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-etcd-recovery 920ee1b link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@LiangquanLi930
Copy link
Member Author

Based on the log from this link, the cluster consistently fails to install, so I think we can ignore it.

@LiangquanLi930
Copy link
Member Author

Based on past jobs, the job at https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-origin-release-4.15-e2e-metal-ipi-ovn-ipv6 will fail permanently, not just the current job.

@Miciah
Copy link
Contributor

Miciah commented Aug 5, 2024

/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

@Miciah: Miciah unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knobunc
Copy link
Contributor

knobunc commented Aug 5, 2024

/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@LiangquanLi930
Copy link
Member Author

@deads2k @sdodson Hi, Could you help to merge this PR? Thanks

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 12, 2024
@sdodson
Copy link
Member

sdodson commented Aug 12, 2024

Got it, thanks @LiangquanLi930

@openshift-merge-bot openshift-merge-bot bot merged commit 229db64 into openshift:release-4.15 Aug 12, 2024
20 of 23 checks passed
@openshift-ci-robot
Copy link

@LiangquanLi930: Jira Issue OCPBUGS-36264: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36264 has been moved to the MODIFIED state.

In response to this:

manual cherry-pick #28880

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@LiangquanLi930: new pull request created: #28998

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 12, 2024
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.15.0-202408121709.p0.g229db64.assembly.stream.el8.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-08-12-233649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miciah Miciah Miciah left review comments

@candita candita candita left review comments

@frobware frobware Awaiting requested review from frobware

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@dgoodwin dgoodwin

@adambkaplan adambkaplan

@candita candita

@gcs278 gcs278

@kasturinarra kasturinarra

@jadhaj jadhaj

@pamoedom pamoedom

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.