Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-38788: [4.16] egressfirewall: skip ping tests in case of hypershift kubevirt on Azure infra #28938

Conversation

orenc1
Copy link
Contributor

@orenc1 orenc1 commented Jul 17, 2024

In case the cluster under test is an HCP/HyperShift cluster of the kubevirt provider, and the management cluster is running on Azure, ICMP responses from outside of the cluster to the guest cluster are getting blocked.
Thus, skipping the ping tests in that case, in addition to the existing exception.
This is a manual backport of #28916

@openshift-ci openshift-ci bot requested review from knobunc and nunnatsa July 17, 2024 11:26
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024
@danwinship
Copy link
Contributor

/approve

@orenc1
Copy link
Contributor Author

orenc1 commented Jul 31, 2024

/label backport-risk-assessed

Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

@orenc1: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@orenc1
Copy link
Contributor Author

orenc1 commented Jul 31, 2024

Hi @danwinship ,
Do you have a permission to add the required backport-risk-assessed label?
Thanks 🙏

@orenc1 orenc1 force-pushed the 4.16_hypershift_kubevirt_skip_ping_azure branch from 906b430 to fbcd1f3 Compare August 12, 2024 08:02
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2024
@openshift-ci openshift-ci bot added e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files and removed lgtm Indicates that a PR is ready to be merged. labels Aug 12, 2024
… on Azure infra

In case the cluster under test is an HCP/HyperShift cluster of the kubevirt provider, and the management cluster
is running on Azure, ICMP responses from outside of the cluster to the guest cluster are getting blocked.
Thus, skipping the ping tests in that case, in addition to the existing exception.

Signed-off-by: Oren Cohen <ocohen@redhat.com>
@orenc1 orenc1 force-pushed the 4.16_hypershift_kubevirt_skip_ping_azure branch from fbcd1f3 to bedef14 Compare August 12, 2024 11:52
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
Copy link
Contributor

openshift-ci bot commented Aug 12, 2024

@orenc1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd bedef14 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway bedef14 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-gcp-ovn-image-ecosystem fbcd1f3 link true /test e2e-gcp-ovn-image-ecosystem
ci/prow/e2e-aws-ovn-kubevirt bedef14 link false /test e2e-aws-ovn-kubevirt
ci/prow/e2e-aws-ovn-single-node-upgrade bedef14 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-builds fbcd1f3 link true /test e2e-gcp-ovn-builds
ci/prow/e2e-aws-ovn-ipsec-serial bedef14 link false /test e2e-aws-ovn-ipsec-serial
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 bedef14 link false /test e2e-vsphere-ovn-dualstack-primaryv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@davidvossel
Copy link
Contributor

/label backport-risk-assessed

Copy link
Contributor

openshift-ci bot commented Aug 20, 2024

@davidvossel: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knobunc knobunc added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 20, 2024
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
Copy link
Contributor

openshift-ci bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, davidvossel, orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@orenc1 orenc1 changed the title [4.16] egressfirewall: skip ping tests in case of hypershift kubevirt on Azure infra NO-JIRA: [4.16] egressfirewall: skip ping tests in case of hypershift kubevirt on Azure infra Aug 21, 2024
@openshift-ci-robot
Copy link

@orenc1: This pull request explicitly references no jira issue.

In response to this:

In case the cluster under test is an HCP/HyperShift cluster of the kubevirt provider, and the management cluster is running on Azure, ICMP responses from outside of the cluster to the guest cluster are getting blocked.
Thus, skipping the ping tests in that case, in addition to the existing exception.
This is a manual backport of #28916

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2024
@orenc1 orenc1 changed the title NO-JIRA: [4.16] egressfirewall: skip ping tests in case of hypershift kubevirt on Azure infra OCPBUGS-38788: [4.16] egressfirewall: skip ping tests in case of hypershift kubevirt on Azure infra Aug 21, 2024
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 21, 2024
@openshift-ci-robot
Copy link

@orenc1: This pull request references Jira Issue OCPBUGS-38788, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-38788 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In case the cluster under test is an HCP/HyperShift cluster of the kubevirt provider, and the management cluster is running on Azure, ICMP responses from outside of the cluster to the guest cluster are getting blocked.
Thus, skipping the ping tests in that case, in addition to the existing exception.
This is a manual backport of #28916

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@orenc1
Copy link
Contributor Author

orenc1 commented Aug 21, 2024

/jira refresh

@openshift-ci-robot
Copy link

@orenc1: This pull request references Jira Issue OCPBUGS-38788, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-38790 to target a version in 4.17.0, but it targets "4.17.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@orenc1: This pull request references Jira Issue OCPBUGS-38788, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@orenc1
Copy link
Contributor Author

orenc1 commented Aug 21, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2024
@openshift-ci-robot
Copy link

@orenc1: This pull request references Jira Issue OCPBUGS-38788, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-38790 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-38790 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocohen@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gangwgr
Copy link
Contributor

gangwgr commented Aug 27, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit be7f872 into openshift:release-4.16 Aug 27, 2024
23 of 29 checks passed
@openshift-ci-robot
Copy link

@orenc1: Jira Issue OCPBUGS-38788: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38788 has been moved to the MODIFIED state.

In response to this:

In case the cluster under test is an HCP/HyperShift cluster of the kubevirt provider, and the management cluster is running on Azure, ICMP responses from outside of the cluster to the guest cluster are getting blocked.
Thus, skipping the ping tests in that case, in addition to the existing exception.
This is a manual backport of #28916

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202408280006.p0.gbe7f872.assembly.stream.el9.
All builds following this will include this PR.

@orenc1 orenc1 deleted the 4.16_hypershift_kubevirt_skip_ping_azure branch August 28, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. e2e-images-update Related to images used by e2e tests jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.