Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-jira: e2e: check for deployer RB only when DeploymentConfig is enabled #28941

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Jul 21, 2024

Follow up for #28939.

To resolve failing e2e in openshift/cluster-version-operator#1066.

@ingvagabund ingvagabund changed the title e2e: check for deployer RB only when DeploymentConfig is enabled no-jira: e2e: check for deployer RB only when DeploymentConfig is enabled Jul 21, 2024
@openshift-ci-robot
Copy link

@ingvagabund: This pull request explicitly references no jira issue.

In response to this:

Follow up for #28939.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 21, 2024
@ingvagabund
Copy link
Member Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node e0b5e7d link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade e0b5e7d link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-ipsec-serial e0b5e7d link false /test e2e-aws-ovn-ipsec-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xueqzhan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 139b945 into openshift:master Jul 22, 2024
22 of 25 checks passed
@ingvagabund ingvagabund deleted the check-for-deployers-rb-only-when-dc-cap-is-enabled branch July 22, 2024 15:50
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.17.0-202407221718.p0.g139b945.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants