-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRKLDS-1431: e2e: migrate DCs to Deployments #28957
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d1ca886
to
e5d212a
Compare
Job Failure Risk Analysis for sha: e5d212a
|
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Job Failure Risk Analysis for sha: a478e09
|
a478e09
to
6c08ffa
Compare
Job Failure Risk Analysis for sha: 6c08ffa
|
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6c08ffa
to
27cb911
Compare
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f280933
to
481a9d3
Compare
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ingvagabund: This pull request references WRKLDS-1431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Job Failure Risk Analysis for sha: 481a9d3
|
Job Failure Risk Analysis for sha: 59ecd44
|
/retest-required |
592fd1a
to
409d1d8
Compare
Based on https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-origin-master-e2e-gcp-ovn-builds the job has been failing for other PRs as well.
Often failing with failed installation |
There's an ongoing discussion in https://redhat-internal.slack.com/archives/C032HSVS71T/p1722529302986619. The current conclusion is workloads QE will create a periodic jobs with all capabilities enabled. That will cover the case where we will still keep exercising DCs.
These are all the tests that have [apigroup:apps..openshift.io] in their name. E.g.:
The still existing tests cover the following cases:
|
I spoke to jan this evening and i understand that workload qe team will setup new periodic jobs and maintain these from 4.17 to test this particular epic. Setting up these jobs will be a collaborative task between openshift qe and workloads qe and this has nothing to with the jobs and profiles that dev has or they look into. Also workloads team will continue to test deploymentconfigs and make sure no tests with deploymentconfigs fail after this feature is merged and continue to have dc tests in our test suite. |
Will it be possible to add any testing as payload blocking? Would be good to make sure we don't accept payloads where we are regressing on features, keep me honest @dgoodwin, would you also expect something blocking to make sure we don't regress? |
Can a periodic job be considered blocking? Maybe, we need to add a new job that gets run every time a new release is created? |
Yes, there's some config in the release repo that you can use to configure a job as informing, once you can show that it passes reliably (I think 20 consecutive builds), then you can promote to blocking, or at least, that's the process for new features, this may be a slightly different requirement |
dfb99cf
to
611169a
Compare
/hold |
Job Failure Risk Analysis for sha: 611169a
|
…emove [apigroup:apps.openshift.io] API dependency
… [apigroup:apps.openshift.io] API dependency
…oup:apps.openshift.io] API dependency
611169a
to
0bfabbb
Compare
Job Failure Risk Analysis for sha: 0bfabbb
|
/retest-required |
…enshift.io] API dependency
…enshift.io] API dependency
…shift.io] API dependency
0bfabbb
to
eca8c26
Compare
Job Failure Risk Analysis for sha: eca8c26
|
/retest-required |
/retest |
/hold cancel |
openshift-eng/ci-test-mapping#148 updates the test mapping. |
@ingvagabund: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: eca8c26
|
Job Failure Risk Analysis for sha: eca8c26
|
Migrated:
[Serial] [sig-auth][Feature:OAuthServer] [RequestHeaders] [IdP] test RequestHeaders IdP [apigroup:config.openshift.io][apigroup:user.openshift.io]
: works without DC API enabled[sig-builds][Feature:Builds][volumes] ...
: migrating with triggers[sig-cli] oc --request-timeout works as expected
: creating a deployment instead of a DC[sig-cli] oc adm build-chain [apigroup:build.openshift.io][apigroup:image.openshift.io][apigroup:project.openshift.io]
: migrating with triggers[sig-cli] oc builds ...
: migrating with triggers[sig-cli] oc debug ensure debug does not depend on a container actually existing for the selected resource
: duplicating for deployments[sig-cli] oc env can set environment variables
: migrating with triggers[sig-cli] oc idle [apigroup:apps.openshift.io][apigroup:route.openshift.io][apigroup:project.openshift.io][apigroup:image.openshift.io] by ...
: duplicated and changed for deployments[sig-cli] oc run can use --image flag correctly
: creating a deployment instead of a DC[sig-cli] oc set image can set images for pods and deployments
: migrating with triggers[sig-cli] oc status returns expected help messages
: works without DC as long as --suggest arg is provided[sig-cli] templates process
: migrating with triggers[sig-devex][Feature:Templates] templateinstance readiness test
: migrating with triggers[sig-devex][Feature:ImageEcosystem][perl][Slow] hot deploy for openshift perl image hot deploy test should work [apigroup:image.openshift.io][apigroup:operator.openshift.io][apigroup:config.openshift.io][apigroup:build.openshift.io][apigroup:apps.openshift.io]
: migrating with triggers + replacing all the waiting code and Deployment -> RS -> pod retrival code.[sig-imageregistry][Feature:ImageLookup] Image policy should update OpenShift object image fields when local names are on
:[sig-network-edge][Feature:Idling] Unidling ...
: simple DC replacement (no triggers)[sig-scheduling][Early] The openshift-apiserver pods [apigroup:apps.openshift.io][apigroup:authorization.openshift.io][apigroup:build.openshift.io][apigroup:image.openshift.io][apigroup:project.openshift.io][apigroup:quota.openshift.io][apigroup:route.openshift.io][apigroup:security.openshift.io][apigroup:template.openshift.io] should be scheduled on different nodes
: already without DC dependency, just removing the apigroup.Ignoring:
[sig-imageregistry][Feature:ImageLookup] Image policy should update OpenShift object image fields when local names are on [apigroup:image.openshift.io][apigroup:apps.openshift.io]
: testing DCs[sig-imageregistry][Feature:ImagePrune][Serial][Suite:openshift/registry/serial][Local] Image hard prune [apigroup:apps.openshift.io][apigroup:user.openshift.io] should delete orphaned blobs [apigroup:image.openshift.io]
: not running at all, fails on missing dc/docker-registry.[sig-imageregistry][Feature:ImagePrune][Serial][Suite:openshift/registry/serial][Local] Image hard prune [apigroup:apps.openshift.io][apigroup:user.openshift.io] should show orphaned blob deletions in dry-run mode [apigroup:image.openshift.io]
: not running at all, fails on missing dc/docker-registry.[sig-devex][Feature:ImageEcosystem][mariadb][Slow] openshift mariadb image Creating from a template should instantiate the template [apigroup:image.openshift.io][apigroup:operator.openshift.io][apigroup:config.openshift.io][apigroup:apps.openshift.io]
: broken[sig-devex][Feature:ImageEcosystem][mysql][Slow] openshift mysql image Creating from a template should instantiate the template [apigroup:apps.openshift.io]
: broken[sig-cli] oc probe can ensure the probe command is functioning as expected on deploymentconfigs [apigroup:apps.openshift.io]
: testing DCsoc explain should contain spec+status for apps.openshift.io [apigroup:apps.openshift.io]
: testing DCsoc explain should contain proper fields description for apps.openshift.io [apigroup:apps.openshift.io]
: testing DCs[sig-cli] oc basics can create deploymentconfig and clusterquota [apigroup:apps.openshift.io]
: testing DCs[sig-scalability][Feature:Performance] Load cluster should populate the cluster [Slow][Serial]
: broken by Use UBI8 instead of SCL images #26072 as the e2e is expected to be run separately: The following error is produced:[sig-scalability]
: can't find any run in https://search.dptools.openshift.org/?search=%5C%5Bsig-scalability%5C%5D&maxAge=48h&context=1&type=junit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job