STOR-1819: Add OpenShift specific CSI certification test #28967
Conversation
jsafrane
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jsafrane: This pull request references STOR-1819 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jsafrane
force-pushed
the
scsi-lun-overflow-final
branch
from
72d9873
to
b078941
Compare
|
I was running into: But it did start once I removed |
jsafrane
force-pushed
the
scsi-lun-overflow-final
branch
from
b078941
to
e77749e
Compare
|
I fixed parsing of the timeout, apparently it must be a string and not a Duration. |
With openshift/origin#28967, openshift-tests accepts additional env. var. TEST_OCP_DRIVER_FILES that points to a file with OCP specific CSI certification tests. There is just one test for now, a test that creates 260 volumes + Pods on a single node and waits for them to complete (with a very long timeout). This test can be expensive, so don't run it unless explicitly enabled by ENABLE_LONG_CSI_CERTIFICATION_TESTS=true In the future, there may be more OCP specific test enabled by TEST_OCP_DRIVER_FILES manifest and I'd like to keep the ability to skip just the long ones somehow. Only the periodic jobs have the long test enabled.
With openshift/origin#28967, openshift-tests accepts additional env. var. TEST_OCP_DRIVER_FILES that points to a file with OCP specific CSI certification tests. There is just one test for now, a test that creates 260 volumes + Pods on a single node and waits for them to complete (with a very long timeout). This test can be expensive, so don't run it unless explicitly enabled by ENABLE_LONG_CSI_CERTIFICATION_TESTS=true In the future, there may be more OCP specific test enabled by TEST_OCP_DRIVER_FILES manifest and I'd like to keep the ability to skip just the long ones somehow. Only the periodic jobs have the long test enabled.
With openshift/origin#28967, openshift-tests accepts additional env. var. TEST_OCP_DRIVER_FILES that points to a file with OCP specific CSI certification tests. There is just one test for now, a test that creates 260 volumes + Pods on a single node and waits for them to complete (with a very long timeout). This test can be expensive, so don't run it unless explicitly enabled by ENABLE_LONG_CSI_CERTIFICATION_TESTS=true In the future, there may be more OCP specific test enabled by TEST_OCP_DRIVER_FILES manifest and I'd like to keep the ability to skip just the long ones somehow. Only the periodic jobs have the long test enabled.
With openshift/origin#28967, openshift-tests accepts additional env. var. TEST_OCP_DRIVER_FILES that points to a file with OCP specific CSI certification tests. There is just one test for now, a test that creates 260 volumes + Pods on a single node and waits for them to complete (with a very long timeout). This test can be expensive, so don't run it unless explicitly enabled by ENABLE_LONG_CSI_CERTIFICATION_TESTS=true In the future, there may be more OCP specific test enabled by TEST_OCP_DRIVER_FILES manifest and I'd like to keep the ability to skip just the long ones somehow. Only the periodic jobs have the long test enabled.
With openshift/origin#28967, openshift-tests accepts additional env. var. TEST_OCP_DRIVER_FILES that points to a file with OCP specific CSI certification tests. There is just one test for now, a test that creates 260 volumes + Pods on a single node and waits for them to complete (with a very long timeout). This test can be expensive, so don't run it unless explicitly enabled by ENABLE_LONG_CSI_CERTIFICATION_TESTS=true In the future, there may be more OCP specific test enabled by TEST_OCP_DRIVER_FILES manifest and I'd like to keep the ability to skip just the long ones somehow. Only the periodic jobs have the long test enabled.
jsafrane
force-pushed
the
scsi-lun-overflow-final
branch
from
e77749e
to
3aa924a
Compare
|
@jsafrane: This pull request references STOR-1819 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
We use testsuite "openshift/csi" to run test against 3rd party CSI drivers as a way to certify them in OpenShift. So far we used upstream tests there. Add OCP specific tests to the suite, based on a new OCP specific YAML manifest provided by the CSI driver vendor. Usage: TEST_OCP_CSI_DRIVER_FILES=azure-disk-ocp.yaml TEST_CSI_DRIVER_FILES=azure-disk-manifest.yaml ./openshift-tests run openshift/csi
Add OpenShift specific test that creates > 256 PVs + Pods on a single node in a large batch. This makes sure that a CSI driver can support larger-ish number of separate volumes per node. There was a case that a CSI driver created too high LUN numbers (256) that was not supported by the Linux kernel. All pods are created at the same time, expecting the CSI driver reports a correct attach limit and the Kubernetes scheduler respects it.
jsafrane
force-pushed
the
scsi-lun-overflow-final
branch
from
26f7c21
to
58e496c
Compare
With openshift/origin#28967, openshift-tests accepts additional env. var. TEST_OCP_CSI_DRIVER_FILES that points to a file with OCP specific CSI certification tests. There is just one test for now, a test that creates 260 volumes + Pods on a single node and waits for them to complete (with a very long timeout). This test can be expensive, so don't run it unless explicitly enabled by ENABLE_LONG_CSI_CERTIFICATION_TESTS=true In the future, there may be more OCP specific test enabled by TEST_OCP_CSI_DRIVER_FILES manifest and I'd like to keep the ability to skip just the long ones somehow. Only the periodic jobs have the long test enabled.
With openshift/origin#28967, openshift-tests accepts additional env. var. TEST_OCP_CSI_DRIVER_FILES that points to a file with OCP specific CSI certification tests. There is just one test for now, a test that creates 260 volumes + Pods on a single node and waits for them to complete (with a very long timeout). This test can be expensive, so don't run it unless explicitly enabled by ENABLE_LONG_CSI_CERTIFICATION_TESTS=true In the future, there may be more OCP specific test enabled by TEST_OCP_CSI_DRIVER_FILES manifest and I'd like to keep the ability to skip just the long ones somehow. Only the periodic jobs have the long test enabled.
With openshift/origin#28967, openshift-tests accepts additional env. var. TEST_OCP_CSI_DRIVER_FILES that points to a file with OCP specific CSI certification tests. There is just one test for now, a test that creates 260 volumes + Pods on a single node and waits for them to complete (with a very long timeout). This test can be expensive, so don't run it unless explicitly enabled by ENABLE_LONG_CSI_CERTIFICATION_TESTS=true In the future, there may be more OCP specific test enabled by TEST_OCP_CSI_DRIVER_FILES manifest and I'd like to keep the ability to skip just the long ones somehow. Only the periodic jobs have the long test enabled.
With openshift/origin#28967, openshift-tests accepts additional env. var. TEST_OCP_CSI_DRIVER_FILES that points to a file with OCP specific CSI certification tests. There is just one test for now, a test that creates 260 volumes + Pods on a single node and waits for them to complete (with a very long timeout). This test can be expensive, so don't run it unless explicitly enabled by ENABLE_LONG_CSI_CERTIFICATION_TESTS=true In the future, there may be more OCP specific test enabled by TEST_OCP_CSI_DRIVER_FILES manifest and I'd like to keep the ability to skip just the long ones somehow. Only the periodic jobs have the long test enabled.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label px-approved |
openshift-ci
bot
added
px-approved
|
@jsafrane: This pull request references STOR-1819 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-ovn-fips |
1 similar comment
|
/test e2e-aws-ovn-fips |
|
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws-ovn-edge-zones |
openshift-merge-bot
bot
merged commit 55f41c0
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
With openshift/origin#28967, openshift-tests accepts additional env. var. TEST_OCP_CSI_DRIVER_FILES that points to a file with OCP specific CSI certification tests. There is just one test for now, a test that creates 260 volumes + Pods on a single node and waits for them to complete (with a very long timeout). This test can be expensive, so don't run it unless explicitly enabled by ENABLE_LONG_CSI_CERTIFICATION_TESTS=true In the future, there may be more OCP specific test enabled by TEST_OCP_CSI_DRIVER_FILES manifest and I'd like to keep the ability to skip just the long ones somehow. Only the 4.18 AWS EBS CSI periodic jobs have the long test enabled.
With openshift/origin#28967, openshift-tests accepts additional env. var. TEST_OCP_CSI_DRIVER_FILES that points to a file with OCP specific CSI certification tests. There is just one test for now, a test that creates 260 volumes + Pods on a single node and waits for them to complete (with a very long timeout). This test can be expensive, so don't run it unless explicitly enabled by ENABLE_LONG_CSI_CERTIFICATION_TESTS=true In the future, there may be more OCP specific test enabled by TEST_OCP_CSI_DRIVER_FILES manifest and I'd like to keep the ability to skip just the long ones somehow. Only the 4.18 AWS EBS CSI periodic jobs have the long test enabled.
Add a new OpenShift-specific test to
openshift/csisuite that test a larger number of volumes used in a pod in sequence (or in manageable chunks). There was a 3rd party CSI driver that overflew a kernel counter after 256th attached volume.This PR introduces OpenShift specific configuration manifest that configures OCP specific tests. There is just one test today, more can come in the future.
Usage:
The test itself selects a random schedulable node, and creates configured nr. of Pods in parallel (260 by default). The test expects that the CSI driver reports correct attachment limit and the Kubernetes scheduler respects it.
We know the scheduler can put more volumes to a node than the CSI driver can handle, however, we expect CSI drivers to handle it (and e.g. return errors).