Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-38086: vertical scaling test should not rely on CPMS replicas #28985

Open
wants to merge 1 commit into
base: release-4.15
Choose a base branch
from
Open

[release-4.15] OCPBUGS-38086: vertical scaling test should not rely on CPMS replicas #28985

wants to merge 1 commit into from
+53 −35

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #28981

/assign openshift-cherrypick-robot

/cherrypick release-4.14

@hasbro17
OCPBUGS-37837: vertical scaling test should not rely on CPMS replicas
898061f 
The vertical scaling test will currently timeout on waiting for the CPMS
status.readyReplicas to scale up to 4 where as in practice that may not happen.
Ensuring that the cluster membership is 3 and checking that the old member has
been removed is enough of a signal that vertical scaling has successfully completed
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 7, 2024
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-38015 has been cloned as Jira Issue OCPBUGS-38086. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-38086: vertical scaling test should not rely on CPMS replicas

In response to this:

This is an automated cherry-pick of #28981

/assign openshift-cherrypick-robot

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-38015: vertical scaling test should not rely on CPMS replicas [release-4.15] OCPBUGS-38086: vertical scaling test should not rely on CPMS replicas Aug 7, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 7, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-38086, which is invalid:

  • expected dependent Jira Issue OCPBUGS-38015 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #28981

/assign openshift-cherrypick-robot

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and hexfusion August 7, 2024 11:51
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 898061f link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn-rt-upgrade 898061f link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-metal-ipi-sdn 898061f link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade 898061f link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 898061f link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-etcd-recovery 898061f link false /test e2e-aws-etcd-recovery
ci/prow/e2e-agnostic-ovn-cmd 898061f link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tjungblu
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 12, 2024
@openshift-ci-robot
Copy link

@tjungblu: This pull request references Jira Issue OCPBUGS-38086, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-38015 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-38015 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact:
/cc @geliu2016

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from geliu2016 August 12, 2024 08:24
@tjungblu
Copy link
Contributor

/lgtm

/label backport-risk-assessed

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 12, 2024

@tjungblu: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/lgtm

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
geliu2016
geliu2016 approved these changes Aug 13, 2024
View reviewed changes
Copy link

@geliu2016 geliu2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label cherry-pick-approved

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: geliu2016, openshift-cherrypick-robot, tjungblu
Once this PR has been reviewed and has the lgtm label, please assign hexfusion for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hasbro17
Copy link
Contributor

hasbro17 commented Sep 3, 2024

/label backport-risk-assessed

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

@hasbro17: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hasbro17
Copy link
Contributor

hasbro17 commented Sep 3, 2024

@deads2k Since Maciej isn't here to field these anymore, would you mind adding the backport label?
For context: this is fixing a timeout flake in our vertical scaling test by not relying on the CPMS's status.readyReplicas field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geliu2016 geliu2016 geliu2016 approved these changes

@csrwng csrwng Awaiting requested review from csrwng

@hexfusion hexfusion Awaiting requested review from hexfusion

Assignees

@openshift-cherrypick-robot openshift-cherrypick-robot

@tjungblu tjungblu

Labels
jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @tjungblu @hasbro17 @geliu2016