Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.0 #227

Open
wants to merge 773 commits into
base: master
Choose a base branch
from
Open

Update to 3.0 #227

wants to merge 773 commits into from

Conversation

machine424
Copy link

@machine424 machine424 commented Sep 25, 2024

to do:

  • keep our new gitignore (synbot)

  • update synbot commands

  • remove remote-write-receiver feature flag setting in CMO

  • auto-gomemlimit and autogomaxprocs? (SNO)

  • fallback_scrape_protocol

To reviewer:
too many commits, please give more attention to the ones I added on top

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2024
Copy link

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
mmorel-35 and others added 25 commits October 6, 2024 16:35
…Error()" and "Equal(t, err.Error()" (prometheus#15094)

* fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()"

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.6 to 4.2.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@a5ac7e5...d632683)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ules/go.uber.org/automaxprocs-1.6.0

Bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0
* textparse: Refactored benchmark.

Signed-off-by: bwplotka <bwplotka@gmail.com>

* Kill sinks, tested, nothing is inlined.

Signed-off-by: bwplotka <bwplotka@gmail.com>

* Addressed comments.

Signed-off-by: bwplotka <bwplotka@gmail.com>

---------

Signed-off-by: bwplotka <bwplotka@gmail.com>
…rlapping-compaction-flag

Add missing flag storage.tsdb.allow-overlapping-compaction
# Conflicts:
#	scrape/scrape.go
…e name

See Parser.Type() function.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
…ules/google.golang.org/grpc-1.67.1

Bump google.golang.org/grpc from 1.66.0 to 1.67.1
…ules/golang.org/x/tools-0.25.0

Bump golang.org/x/tools from 0.24.0 to 0.25.0
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.25.0 to 0.26.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.25.0...v0.26.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…ules/golang.org/x/tools-0.26.0

build(deps): bump golang.org/x/tools from 0.25.0 to 0.26.0
…ules/github.com/gophercloud/gophercloud-1.14.1

Bump github.com/gophercloud/gophercloud from 1.14.0 to 1.14.1
… Units. (prometheus#15095)

Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: Julien <roidelapluie@o11y.eu>
This unifies the documentation of float literals and time durations
and updates all references to the old definitions.

Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Extracted HTTP client options (e.g., authentication, proxy settings,
TLS configuration, and custom headers) into a dedicated section for
improved clarity and organization. This will centralize all HTTP-related
options from prometheus/common in one place within the documentation.

The remaining HTTP-related settings in sections (e.g. Service Discovery)
will be moved in a follow-up PR to further unify the documentation
structure.

Signed-off-by: Julien <roidelapluie@o11y.eu>
Because we are reimplementing the `IndexReader` to fetch in-order and
out-of-order chunks together, we must reproduce the behaviour of
`Head.indexRange()`, which floors the minimum time queried at `head.MinTime()`.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Signed-off-by: Julien <roidelapluie@o11y.eu>
Signed-off-by: Julien <roidelapluie@o11y.eu>
Signed-off-by: Julien <roidelapluie@o11y.eu>
Signed-off-by: Julien <roidelapluie@o11y.eu>
Signed-off-by: Julien <roidelapluie@o11y.eu>
bboreham and others added 6 commits November 24, 2024 16:54
…unding-keys

fix!: stop unbounded memory usage from query log
Previously, the api was evaluating this regex to determine if the label
name was valid or not:

https://github.com/prometheus/common/blob/14bac55a992f7b83ab9d147a041e274606bdb607/model/labels.go#L94

However, I believe that the `IsValid()` function is what ought to be
used in the brave new utf8 era.

**Before**

```
$ curl localhost:9090/api/v1/label/host.name/values
{"status":"error","errorType":"bad_data","error":"invalid label name: \"host.name\""}
```

**After**

```
$ curl localhost:9090/api/v1/label/host.name/values
{"status":"success","data":["localhost"]}
```

It's very likely that I'm missing something here or you were already
planning to do this at some point but I just encountered this issue and
figured I'd give it a go.

Signed-off-by: Owen Williams <owen.williams@grafana.com>
Signed-off-by: Owen Williams <owen.williams@grafana.com>
Add support for utf8 names on /v1/label/:name/values endpoint
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
@machine424
Copy link
Author

/close
superseded by #237

@openshift-ci openshift-ci bot closed this Dec 16, 2024
Copy link

openshift-ci bot commented Dec 16, 2024

@machine424: Closed this PR.

In response to this:

/close
superseded by #237

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@machine424
Copy link
Author

/reopen
for tests

@openshift-ci openshift-ci bot reopened this Dec 18, 2024
Copy link

openshift-ci bot commented Dec 18, 2024

@machine424: Reopened this PR.

In response to this:

/reopen
for tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2024
@machine424 machine424 changed the title Test 3.0 Update to 3.0 Dec 18, 2024
@machine424
Copy link
Author

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/prometheus-operator#321
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/prometheus-operator#321
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/prometheus-operator#321

@machine424
Copy link
Author

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/prometheus-operator#321
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/prometheus-operator#321
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/prometheus-operator#321

@machine424
Copy link
Author

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/prometheus-operator#321 openshift/thanos#154
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/prometheus-operator#321 openshift/thanos#154
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/prometheus-operator#321 openshift/thanos#154

@machine424
Copy link
Author

/retest-required

Copy link

openshift-ci bot commented Dec 23, 2024

@machine424: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn a377671 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade a377671 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-agnostic-cmo a377671 link true /test e2e-agnostic-cmo

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@machine424
Copy link
Author

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/cluster-monitoring-operator#2544
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/cluster-monitoring-operator#2544
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/cluster-monitoring-operator#2544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.