Updated macro and variable decls to fit to POSIX and C89 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- macro __LINUX__ is replaced by __UNIX__ - removed variable declarations from for Signed-off-by: Sergey Oblomov <sergeyo@mellanox.com>
|
@jdinan could you check this PR on MAC? thank you |
|
I don't see any reason why this wouldn't work on Mac, since it only renames the symbol. But, the approach being used is still not good. For example, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forloopfixes #39
Signed-off-by: Sergey Oblomov sergeyo@mellanox.com