Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SCM wrapping #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

imphil
Copy link
Contributor

@imphil imphil commented Sep 12, 2019

The SCM provides a system reset functionality which we didn't explicitly expose in osd_cl_scm so far. Add that.

Also wrap this functionality in the Python API.

This hardware functionality of the SCM was not exposed through
osd_cl_scm, filling that gap.
We have API docs in header files, remove redundant documentation from
the source file.
No bindings for osd_cl_scm_get_subnetinfo() so far, as this would
require more work to get the subnet info passed in suitable form into a
dict (and we don't need it at the moment).
@koenenwmn
Copy link

When I try to import osd after installing this version I get an ImportError: <path_to_osd-sw>/src/python/osd.cpython-35m-x86_64-linux-gnu.so: undefined symbol: osd_cl_scm_system_reset
Same problem when I run the tests:

______________________________________________________________________________________________________________________ ERROR collecting tests/test_core.py _______________________________________________________________________________________________________________________
ImportError while importing test module '<path_to_osd-sw>/src/python/tests/test_core.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_core.py:16: in <module>
    import osd
E   ImportError: <path_to_osd-sw>/src/python/osd.cpython-35m-x86_64-linux-gnu.so: undefined symbol: osd_cl_scm_system_reset
_____________________________________________________________________________________________________________________ ERROR collecting tests/test_hostmod.py _____________________________________________________________________________________________________________________
ImportError while importing test module '<path_to_osd-sw>/src/python/tests/test_hostmod.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_hostmod.py:20: in <module>
    import osd
E   ImportError: <path_to_osd-sw>/src/python/osd.cpython-35m-x86_64-linux-gnu.so: undefined symbol: osd_cl_scm_system_reset

@imphil
Copy link
Contributor Author

imphil commented Sep 16, 2019

You need to rebuild and install libosd first to make this symbol available.

(libosd as from this branch.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants