Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWCore] Inject Library with javax.inject.provider #2823

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

LZRS
Copy link
Contributor

@LZRS LZRS commented Oct 17, 2023

to protect against instantiation in the main thread

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2820

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

to protect against instantiation in the main thread
@LZRS LZRS self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2823 (bd131ca) into mwcore-dev (303a210) will not change coverage.
The diff coverage is 60.0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             mwcore-dev   #2823   +/-   ##
============================================
  Coverage          68.2%   68.2%           
  Complexity          901     901           
============================================
  Files               164     164           
  Lines              7321    7321           
  Branches           1035    1035           
============================================
  Hits               4998    4998           
  Misses             1667    1667           
  Partials            656     656           
Flag Coverage Δ
engine 68.2% <60.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/engine/ui/questionnaire/QuestionnaireActivity.kt 77.3% <100.0%> (ø)
.../engine/ui/questionnaire/QuestionnaireViewModel.kt 73.7% <100.0%> (ø)
...hircore/engine/ui/appsetting/AppSettingActivity.kt 27.7% <0.0%> (ø)

@LZRS LZRS requested a review from sevenreup October 17, 2023 15:43
@LZRS LZRS marked this pull request as ready for review October 17, 2023 15:43
@LZRS LZRS merged commit 01cb077 into mwcore-dev Oct 19, 2023
4 checks passed
@LZRS LZRS deleted the 2820-inject-libraryevaluator-with-provider branch October 19, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants