Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mwcore add new contact tags and overflow menu profile #2861

Conversation

evance-mose
Copy link

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@evance-mose evance-mose self-assigned this Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2861 (88ac7c4) into mwcore-dev (b717981) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             mwcore-dev   #2861   +/-   ##
============================================
  Coverage          68.3%   68.3%           
  Complexity          901     901           
============================================
  Files               164     164           
  Lines              7338    7344    +6     
  Branches           1037    1037           
============================================
+ Hits               5013    5019    +6     
  Misses             1667    1667           
  Partials            658     658           
Flag Coverage Δ
engine 68.3% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ister/fhircore/engine/domain/model/HealthStatus.kt 70.8% <100.0%> (+9.7%) ⬆️

@evance-mose evance-mose merged commit dbe4772 into mwcore-dev Nov 16, 2023
4 checks passed
@evance-mose evance-mose deleted the mwcore-add-new-contact-tags-and-thier-overflowmenu-profile branch November 16, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants