Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWCore] Enhance StructureMap transform service with Search and Reverse reference #3028

Closed
wants to merge 2 commits into from

Conversation

sevenreup
Copy link

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@sevenreup sevenreup self-assigned this Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ab836af) 67.6% compared to head (58bedc3) 67.6%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             mwcore-dev   #3028   +/-   ##
============================================
  Coverage          67.6%   67.6%           
  Complexity          901     901           
============================================
  Files               165     165           
  Lines              7384    7394   +10     
  Branches           1045    1048    +3     
============================================
+ Hits               4997    5004    +7     
  Misses             1741    1741           
- Partials            646     649    +3     
Flag Coverage Δ
engine 67.6% <76.9%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ore/engine/util/helper/TransformSupportServices.kt 82.7% <83.3%> (-1.9%) ⬇️
...ircore/engine/util/extension/ReferenceExtension.kt 72.7% <71.4%> (-2.3%) ⬇️

@sevenreup sevenreup assigned evance-mose and unassigned sevenreup Feb 13, 2024
@LZRS LZRS closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants