Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of Primitive Datatypes from SharedPreferences to PreferenceDataStore #3205

Draft
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

DebbieArita
Copy link
Contributor

@DebbieArita DebbieArita commented Apr 18, 2024

Co-authored-by: Brandy brandyariana99@gmail.com
Co-authored-by: Debbie debbiearita96@gmail.com

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2930

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Co-authored-by: Brandy brandyariana99@gmail.com
Co-authored-by: Debbie debbiearita96@gmail.com
@DebbieArita DebbieArita marked this pull request as draft April 18, 2024 15:09
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.7%. Comparing base (6fc15b0) to head (01202e7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3205     +/-   ##
=========================================
+ Coverage     27.1%   27.7%   +0.6%     
+ Complexity     775     750     -25     
=========================================
  Files          279     278      -1     
  Lines        14563   13665    -898     
  Branches      2608    2477    -131     
=========================================
- Hits          3957    3798    -159     
+ Misses       10065    9342    -723     
+ Partials       541     525     -16     
Flag Coverage Δ
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...core/engine/configuration/ConfigurationRegistry.kt 68.0% <ø> (-0.5%) ⬇️
...er/fhircore/engine/data/local/DefaultRepository.kt 60.4% <ø> (+1.3%) ⬆️
...e/engine/data/local/register/RegisterRepository.kt 70.4% <ø> (ø)
...r/fhircore/engine/datastore/PreferenceDataStore.kt 66.6% <ø> (-2.6%) ⬇️
...gister/fhircore/engine/rulesengine/RulesFactory.kt 65.0% <ø> (-2.5%) ⬇️
...gister/fhircore/engine/sync/SyncListenerManager.kt 95.2% <ø> (-0.3%) ⬇️
...est/data/report/measure/MeasureReportRepository.kt 0.0% <ø> (ø)
...hircore/quest/ui/appsetting/AppSettingViewModel.kt 2.2% <ø> (+<0.1%) ⬆️
...register/fhircore/quest/ui/login/LoginViewModel.kt 1.9% <ø> (+0.2%) ⬆️
...egister/fhircore/quest/ui/main/AppMainViewModel.kt 3.6% <ø> (+0.3%) ⬆️
... and 4 more

... and 51 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate SharedPreferences to DataStore
3 participants