-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade FHIR SDK dependencies ⬆️ #3423
Conversation
df6625a
to
4fbcf69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR works as expected for the use cases I have tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CQL works in ZEIR but as Measure Reporting is broken
Exception thrown with measureUrl: https://fhir.labs.smartregister.org/fhir/Measure/ClinicAttendance
java.lang.NullPointerException: id is required on all Elements of type: Measure.group.population
KM is looking for us to provide an ID as part of the params
/** Loads resources from IGs listed in dependencies. */
suspend fun loadResources(
resourceType: String,
url: String? = null,
id: String? = null,
name: String? = null,
version: String? = null,
):
@dubdabasoduba @owais-vd Can we also test this on $apply ? Aug 5th NB. Canonical names to also use URL in the upcoming update on SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, no issues so far! with 1.1.0-preview13.1-SNAPSHOT
We can merge #3428 after this PR was merged
From my investigations it appears that the group population id is now mandatory so you will need to include it in your measure jsons - see this sample from the FHIR SDK I could not find any HL7 FHIR documentation to back it as a required field but I did come across this extension in some IG which introduces it as an extension - https://build.fhir.org/ig/HL7/davinci-deqm/StructureDefinition-extension-populationReference.html Not sure why the clinical reasoning library has made it mandatory. |
e41426d
to
0562514
Compare
There are changes made to the FhirEngineImpl methods/functions. We will no longer need the IO dispatcher in the default repository class functions. |
a5c7252
to
896ae47
Compare
819aea5
to
681073e
Compare
681073e
to
d95173f
Compare
d673f67
to
6e78780
Compare
04e66da
to
be85f08
Compare
- Fix build - Fix reporting NPE
- Update Kujaku library version - Revert offline map downloads configuration via Kujaku network change receiver
- Fix code coverage reporting
e70c7da
to
7f4da95
Compare
8ee27c0
to
5ed582a
Compare
5ed582a
to
053bfad
Compare
- Disable Failing Unit Test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3421
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file