Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement event management to close custom resources via the backgrond Worker #3483

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

Lentumunai-Mark
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3482

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

…nd worker.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
@Lentumunai-Mark Lentumunai-Mark added the Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 27.2%. Comparing base (115c4f4) to head (01924cb).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...tregister/fhircore/engine/task/FhirResourceUtil.kt 50.0% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3483     +/-   ##
=========================================
- Coverage     27.2%   27.2%   -0.1%     
- Complexity     742     749      +7     
=========================================
  Files          276     275      -1     
  Lines        13811   13940    +129     
  Branches      2504    2532     +28     
=========================================
+ Hits          3764    3794     +30     
- Misses        9540    9622     +82     
- Partials       507     524     +17     
Flag Coverage Δ
engine 64.3% <66.6%> (-0.3%) ⬇️
geowidget 12.5% <ø> (+1.1%) ⬆️
quest 5.5% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...er/fhircore/engine/data/local/DefaultRepository.kt 65.1% <100.0%> (+0.1%) ⬆️
...r/fhircore/engine/task/FhirResourceExpireWorker.kt 100.0% <100.0%> (ø)
...tregister/fhircore/engine/task/FhirResourceUtil.kt 82.9% <50.0%> (-3.0%) ⬇️

... and 8 files with indirect coverage changes

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
@Lentumunai-Mark Lentumunai-Mark marked this pull request as ready for review September 10, 2024 14:02
@Lentumunai-Mark Lentumunai-Mark removed the Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions label Sep 10, 2024
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
dubdabasoduba and others added 2 commits September 12, 2024 11:45
…/task/FhirResourceExpireWorker.kt

Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com>
…/task/FhirResourceUtil.kt

Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com>
Copy link
Member

@dubdabasoduba dubdabasoduba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marklosh Please update the event management documentation to reflect what you have done. Also, does this mean the team target service requests should update their confirms

@dubdabasoduba
Copy link
Member

@marklosh Please update the event management documentation to reflect your actions. Also, does this mean the team target service requests should update their confirms

This is unnecessary.

@dubdabasoduba dubdabasoduba merged commit 2601cd0 into main Sep 12, 2024
5 checks passed
@dubdabasoduba dubdabasoduba deleted the Fix/Close-custom-resources branch September 12, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close resources not linked to careplan via event management.
3 participants