Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exit Dialog #3487

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add Exit Dialog #3487

wants to merge 5 commits into from

Conversation

hamza-vd
Copy link
Contributor

@hamza-vd hamza-vd commented Sep 11, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3479

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@hamza-vd hamza-vd changed the title Add exit dialog Add Exit Dialog Sep 11, 2024
@hamza-vd hamza-vd marked this pull request as draft September 11, 2024 12:22
@hamza-vd hamza-vd assigned hamza-vd and unassigned hamza-vd Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 27.1%. Comparing base (2f8055b) to head (53cd81e).

Files with missing lines Patch % Lines
...register/fhircore/quest/ui/main/AppMainActivity.kt 4.3% 22 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3487     +/-   ##
=========================================
- Coverage     27.2%   27.1%   -0.1%     
  Complexity     749     749             
=========================================
  Files          275     275             
  Lines        13940   13963     +23     
  Branches      2532    2536      +4     
=========================================
+ Hits          3794    3795      +1     
- Misses        9622    9644     +22     
  Partials       524     524             
Flag Coverage Δ
engine 64.3% <ø> (ø)
geowidget 12.5% <ø> (ø)
quest 5.5% <4.3%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...register/fhircore/quest/ui/main/AppMainActivity.kt 4.8% <4.3%> (-0.2%) ⬇️

@hamza-vd
Copy link
Contributor Author

Dialog content

@hamza-vd hamza-vd marked this pull request as ready for review September 16, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override onBackPressed() and prompt user before exiting from App
2 participants