Update text for no service points found #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-odhiambo
requested changes
Sep 12, 2024
| @@ -123,7 +123,7 @@ | |||
| <string name="submit_questionnaire">Submit</string> | |||
| <string name="invalid_base_resource">The base resource for GeoWidgetConfiguration MUST be Location</string> | |||
| <string name="no_search_coonfigs_provided">No configs provided for search bar</string> | |||
| <string name="no_found_locations_matching_text">No location found matching text \"%1$s\"</string> | |||
| <string name="no_found_locations_matching_text">No caregiver found matching text \"%1$s\"</string> | |||
There was a problem hiding this comment.
@owais-vd This change should not be here. But pushed to the Strings XML file of the build variant
There was a problem hiding this comment.
@f-odhiambo done
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3491 +/- ##
=========================================
- Coverage 27.2% 27.2% -0.1%
Complexity 756 756
=========================================
Files 278 278
Lines 14239 14241 +2
Branches 2582 2583 +1
=========================================
- Hits 3883 3880 -3
- Misses 9818 9824 +6
+ Partials 538 537 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ellykits
requested changes
Sep 19, 2024
...id/geowidget/src/main/java/org/smartregister/fhircore/geowidget/screens/GeoWidgetFragment.kt
Outdated
Show resolved
Hide resolved
...est/src/main/java/org/smartregister/fhircore/quest/ui/geowidget/GeoWidgetLauncherFragment.kt
Outdated
Show resolved
Hide resolved
ellykits
requested changes
Sep 19, 2024
...id/geowidget/src/main/java/org/smartregister/fhircore/geowidget/screens/GeoWidgetFragment.kt
Outdated
Show resolved
Hide resolved
...id/geowidget/src/main/java/org/smartregister/fhircore/geowidget/screens/GeoWidgetFragment.kt
Outdated
Show resolved
Hide resolved
dubdabasoduba
requested changes
Sep 19, 2024
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
ellykits
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes [link to issue]
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile