-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PDF config properties in QuestionnaireConfig #3498
base: main
Are you sure you want to change the base?
Conversation
Initially using QuestionnaireConfig for simplicity.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3498 +/- ##
=======================================
Coverage 27.2% 27.2%
- Complexity 749 753 +4
=======================================
Files 275 276 +1
Lines 13940 13996 +56
Branches 2532 2542 +10
=======================================
+ Hits 3794 3815 +21
- Misses 9622 9657 +35
Partials 524 524
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1d85407
to
c9ae8fb
Compare
android/engine/src/main/java/org/smartregister/fhircore/engine/pdf/HtmlPopulator.kt
Outdated
Show resolved
Hide resolved
android/engine/src/main/java/org/smartregister/fhircore/engine/pdf/HtmlPopulator.kt
Outdated
Show resolved
Hide resolved
android/engine/src/main/java/org/smartregister/fhircore/engine/pdf/HtmlPopulator.kt
Outdated
Show resolved
Hide resolved
android/engine/src/main/java/org/smartregister/fhircore/engine/configuration/PdfConfig.kt
Outdated
Show resolved
Hide resolved
android/engine/src/main/java/org/smartregister/fhircore/engine/configuration/PdfConfig.kt
Outdated
Show resolved
Hide resolved
.../engine/src/main/java/org/smartregister/fhircore/engine/configuration/QuestionnaireConfig.kt
Show resolved
Hide resolved
android/engine/src/main/java/org/smartregister/fhircore/engine/pdf/HtmlPopulator.kt
Outdated
Show resolved
Hide resolved
android/quest/src/main/java/org/smartregister/fhircore/quest/ui/pdf/PdfLauncherFragment.kt
Show resolved
Hide resolved
android/quest/src/test/java/org/smartregister/fhircore/quest/ui/pdf/PdfLauncherFragmentTest.kt
Show resolved
Hide resolved
android/quest/src/test/java/org/smartregister/fhircore/quest/ui/pdf/PdfLauncherFragmentTest.kt
Show resolved
Hide resolved
@FikriMilano Can you share a sample content for the |
f454707
to
c5aab3a
Compare
…-and-refactor-pdf-config
@ellykits see this file docs/engineering/app/configuring/pdf-generation.mdx |
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideMigration guide from QuestionnaireConfig to PdfConfig for PDF generation purpose.
From:
To:
Code Reviewer Checklist
strings.xml
file