Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search latest QR in PdfLauncherViewModel #3499

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

FikriMilano
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3493

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@FikriMilano FikriMilano self-assigned this Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.1%. Comparing base (2f8055b) to head (638bb42).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ster/fhircore/quest/ui/pdf/PdfLauncherViewModel.kt 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3499     +/-   ##
=========================================
- Coverage     27.2%   27.1%   -0.1%     
  Complexity     749     749             
=========================================
  Files          275     275             
  Lines        13940   13965     +25     
  Branches      2532    2534      +2     
=========================================
+ Hits          3794    3796      +2     
- Misses        9622    9645     +23     
  Partials       524     524             
Flag Coverage Δ
engine 64.3% <ø> (ø)
geowidget 11.5% <ø> (-1.1%) ⬇️
quest 5.5% <0.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ster/fhircore/quest/ui/pdf/PdfLauncherViewModel.kt 14.2% <0.0%> (+14.2%) ⬆️

... and 1 file with indirect coverage changes

@ellykits ellykits merged commit 97a75a0 into main Sep 19, 2024
4 of 5 checks passed
@ellykits ellykits deleted the 3493-search-latest-qr branch September 19, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching QR in the PDF generation flow does not return the latest version
2 participants