Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Questionnaire submission improvements #3509

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

LZRS
Copy link
Contributor

@LZRS LZRS commented Sep 18, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3503

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS LZRS self-assigned this Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 40.38462% with 62 lines in your changes missing coverage. Please review.

Project coverage is 27.2%. Comparing base (6fc15b0) to head (a688773).

Files with missing lines Patch % Lines
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 33.3% 28 Missing and 2 partials ⚠️
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 0.0% 29 Missing ⚠️
...ngine/util/validation/ResourceValidationRequest.kt 90.0% 0 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3509     +/-   ##
=========================================
+ Coverage     27.1%   27.2%   +0.1%     
- Complexity     775     777      +2     
=========================================
  Files          279     279             
  Lines        14563   14572      +9     
  Branches      2608    2616      +8     
=========================================
+ Hits          3957    3978     +21     
+ Misses       10065   10049     -16     
- Partials       541     545      +4     
Flag Coverage Δ
engine 63.8% <90.0%> (+<0.1%) ⬆️
geowidget 16.0% <ø> (ø)
quest 5.8% <20.2%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ngine/util/validation/ResourceValidationRequest.kt 90.0% <90.0%> (ø)
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 2.7% <0.0%> (-1.1%) ⬇️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 5.7% <33.3%> (+2.5%) ⬆️

... and 1 file with indirect coverage changes

during questionnaire response submission
@LZRS LZRS force-pushed the handle-submission-perf-improvements branch from b5e986c to 5af63ad Compare October 18, 2024 16:13
@LZRS LZRS force-pushed the handle-submission-perf-improvements branch from 206ef9c to d70450e Compare November 5, 2024 14:05
@LZRS LZRS marked this pull request as ready for review November 5, 2024 14:09
@LZRS LZRS requested review from ellykits and Rkareko November 5, 2024 14:09
@LZRS LZRS force-pushed the handle-submission-perf-improvements branch from d70450e to a688773 Compare November 7, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FhirValidator slowing down saving of questionnaires in debug mode
1 participant