Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI freeze on launch register screen #3599

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fix UI freeze on launch register screen #3599

merged 3 commits into from
Nov 12, 2024

Conversation

ellykits
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3592

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 9.25926% with 49 lines in your changes missing coverage. Please review.

Project coverage is 27.1%. Comparing base (6fc15b0) to head (4114209).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...er/fhircore/quest/ui/register/RegisterViewModel.kt 0.0% 39 Missing ⚠️
...ter/fhircore/quest/ui/register/RegisterFragment.kt 0.0% 6 Missing ⚠️
...ister/fhircore/quest/ui/register/RegisterScreen.kt 0.0% 3 Missing ⚠️
...e/quest/ui/register/components/RegisterCardList.kt 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3599     +/-   ##
=========================================
- Coverage     27.1%   27.1%   -0.1%     
+ Complexity     775     774      -1     
=========================================
  Files          279     280      +1     
  Lines        14563   14571      +8     
  Branches      2608    2607      -1     
=========================================
+ Hits          3957    3959      +2     
- Misses       10065   10071      +6     
  Partials       541     541             
Flag Coverage Δ
engine 63.7% <ø> (ø)
geowidget 16.0% <ø> (ø)
quest 5.7% <9.2%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...fhircore/quest/ui/register/RegisterUiCountState.kt 100.0% <100.0%> (ø)
...ster/fhircore/quest/ui/register/RegisterUiState.kt 100.0% <ø> (ø)
...e/quest/ui/register/components/RegisterCardList.kt 0.0% <0.0%> (ø)
...ister/fhircore/quest/ui/register/RegisterScreen.kt 0.0% <0.0%> (ø)
...ter/fhircore/quest/ui/register/RegisterFragment.kt 0.0% <0.0%> (ø)
...er/fhircore/quest/ui/register/RegisterViewModel.kt 0.0% <0.0%> (ø)

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Copy link
Contributor

@Lentumunai-Mark Lentumunai-Mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ellykits ellykits merged commit 4217119 into main Nov 12, 2024
4 of 5 checks passed
@ellykits ellykits deleted the 3592-fix-ui-freeze branch November 12, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI freezes when switching from Map to Register view
2 participants