Ensure correct this context for addMembership function to call the blur method correctly. Fixes #10555 #10560
Conversation
…ontext is available.
| if (domElement && typeof domElement.blur === 'function') { | ||
| domElement.blur(); // avoid keeping focus on the button | ||
| } |
There was a problem hiding this comment.
This is a defensive fix, but since addMembership is only called from one place, I think it would be cleaner to move this blur call to the caller, or even replace this with a closure that blurs the element, which would explicitly be in scope:
As it is, if acceptEntity has to bail for some reason, it won’t blur the element, which might result in the menu getting stuck on screen.
There was a problem hiding this comment.
Thank you for the suggestion @1ec5 ! I completely agree that handling the blur() in a closure at the .on('accept') level would ensure the element is blurred reliably and keeps the UI logic separate from addMembership. I will updat the code to use the closure approach, which explicitly handles the blurring before calling acceptEntity.
|
I've updated the PR with the updated code to use the closure approach, which explicitly handles the blurring before calling acceptEntity. This change aligns with the feedback and avoids potential issues with the menu getting stuck on screen. Let me know if there are any further adjustments you'd recommend! 🙌 |
|
Thank you very much @1ec5 ! Hoping to be more involved. |
Fixes issue #10555
thisreference explicitly to theaddMembershipfunction to ensure the correct context is available.thiswas undefined due to implicit context binding in event handlers.acceptEntityto pass the triggering DOM element explicitly as a parameter.