Test note/tag output created at ActiveRecord level

Added testing of note XML, JSON, GPX, RSS and feed outputs (with tags)
when note (and tags) are created on FactoryBot / ActiveRecord level.

test/controllers/api/notes_controller_test.rb

@@ -594,6 +594,8 @@ def test_reopen_fail
 
     def test_show_success
       open_note = create(:note_with_comments)
+      create(:note_tag, :note => open_note, :k => "created_by", :v => "OSM_TEST")
+      create(:note_tag, :note => open_note, :k => "source", :v => "OSM_TEST_SURVEY")
 
       get api_note_path(open_note, :format => "xml")
       assert_response :success
@@ -610,6 +612,8 @@ def test_show_success
             assert_select "comment", :count => 1
           end
         end
+        assert_select "tag[k='created_by'][v='OSM_TEST']", :count => 1
+        assert_select "tag[k='source'][v='OSM_TEST_SURVEY']", :count => 1
       end
 
       get api_note_path(open_note, :format => "rss")
@@ -624,6 +628,8 @@ def test_show_success
             assert_select "geo|lat", open_note.lat.to_s
             assert_select "geo|long", open_note.lon.to_s
             assert_select "georss|point", "#{open_note.lon} #{open_note.lon}"
+            assert_select "tag[k='created_by'][v='OSM_TEST']", :count => 1
+            assert_select "tag[k='source'][v='OSM_TEST_SURVEY']", :count => 1
           end
         end
       end
@@ -643,6 +649,8 @@ def test_show_success
       assert_equal close_api_note_url(open_note, :format => "json"), js["properties"]["close_url"]
       assert_equal open_note.created_at.to_s, js["properties"]["date_created"]
       assert_equal open_note.status, js["properties"]["status"]
+      assert_equal "OSM_TEST", js["properties"]["tags"]["created_by"]
+      assert_equal "OSM_TEST_SURVEY", js["properties"]["tags"]["source"]
 
       get api_note_path(open_note, :format => "gpx")
       assert_response :success
@@ -658,6 +666,8 @@ def test_show_success
             assert_select "url", api_note_url(open_note, :format => "gpx")
             assert_select "comment_url", comment_api_note_url(open_note, :format => "gpx")
             assert_select "close_url", close_api_note_url(open_note, :format => "gpx")
+            assert_select "tag[k='created_by'][v='OSM_TEST']", :count => 1
+            assert_select "tag[k='source'][v='OSM_TEST_SURVEY']", :count => 1
           end
         end
       end
@@ -1171,18 +1181,30 @@ def test_search_bad_params
 
     def test_feed_success
       position = (1.1 * GeoRecord::SCALE).to_i
-      create(:note_with_comments, :latitude => position, :longitude => position)
-      create(:note_with_comments, :latitude => position, :longitude => position)
+      a_note = create(:note_with_comments, :latitude => position, :longitude => position)
+      create(:note_tag, :note => a_note, :k => "created_by", :v => "OSM_TEST")
+      create(:note_tag, :note => a_note, :k => "source", :v => "OSM_TEST_SURVEY")
+      b_note = create(:note_with_comments, :latitude => position, :longitude => position)
+      create(:note_tag, :note => b_note, :k => "created_by", :v => "OSM_TEST")
+      create(:note_tag, :note => b_note, :k => "source", :v => "OSM_TEST_SURVEY")
       position = (1.5 * GeoRecord::SCALE).to_i
-      create(:note_with_comments, :latitude => position, :longitude => position)
-      create(:note_with_comments, :latitude => position, :longitude => position)
+      c_note = create(:note_with_comments, :latitude => position, :longitude => position)
+      create(:note_tag, :note => c_note, :k => "created_by", :v => "OSM_TEST")
+      create(:note_tag, :note => c_note, :k => "source", :v => "OSM_TEST_SURVEY")
+      d_note = create(:note_with_comments, :latitude => position, :longitude => position)
+      create(:note_tag, :note => d_note, :k => "created_by", :v => "OSM_TEST")
+      create(:note_tag, :note => d_note, :k => "source", :v => "OSM_TEST_SURVEY")
 
       get feed_api_notes_path(:format => "rss")
       assert_response :success
       assert_equal "application/rss+xml", @response.media_type
       assert_select "rss", :count => 1 do
         assert_select "channel", :count => 1 do
-          assert_select "item", :count => 4
+          assert_select "item", :count => 4 do |items|
+            items.each do |item|
+              assert_select item, "tag", :count => 2
+            end
+          end
         end
       end