Skip to content

Commit

Permalink
Change block end column to display strictly ends_at
Browse files Browse the repository at this point in the history
Could display when block was viewed before. That's going to be unintuitive if sorting by different times is introduced.
  • Loading branch information
AntonKhorev committed Aug 24, 2024
1 parent 965d7b9 commit cfaeb38
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 9 deletions.
12 changes: 8 additions & 4 deletions app/helpers/user_blocks_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,20 @@ def block_short_status(block)
if block.active?
if block.needs_view?
if block.ends_at > Time.now.utc
t("user_blocks.helper.short.until_end_and_login")
t("user_blocks.helper.short.active_unread")
else
t("user_blocks.helper.short.until_login")
t("user_blocks.helper.short.expired_unread")
end
else
t("user_blocks.helper.short.until_end")
t("user_blocks.helper.short.active")
end
else
if block.revoker_id.nil?
t("user_blocks.helper.short.ended")
if block.updated_at > block.ends_at
t("user_blocks.helper.short.read_html", :time => block_short_time_in_past(block.updated_at))
else
t("user_blocks.helper.short.ended")
end
else
t("user_blocks.helper.short.revoked_html", :name => link_to(block.revoker.display_name, block.revoker))
end
Expand Down
4 changes: 2 additions & 2 deletions app/views/user_blocks/_block.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
<% end %>
<td><%= h truncate(block.reason) %></td>
<td><%= block_short_time_in_past(block.created_at) %></td>
<% if block.active? %>
<% if block.ends_at > Time.now.utc %>
<td><%= block_short_time_in_future(block.ends_at) %></td>
<% else %>
<td><%= block_short_time_in_past([block.ends_at, block.updated_at].max) %></td>
<td><%= block_short_time_in_past(block.ends_at) %></td>
<% end %>
<td><%= h block_short_status(block) %></td>
<td><%= link_to t(".show"), block %></td>
Expand Down
7 changes: 4 additions & 3 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2992,9 +2992,10 @@ en:
short:
ended: "ended"
revoked_html: "revoked by %{name}"
until_end: "until end"
until_login: "until login"
until_end_and_login: "until end & login"
active: "active"
active_unread: "active unread"
expired_unread: "expired unread"
read_html: "read at %{time}"
time_in_future_title: "%{time_absolute}; in %{time_relative}"
time_in_past_title: "%{time_absolute}; %{time_relative}"
blocks_on:
Expand Down

0 comments on commit cfaeb38

Please sign in to comment.