Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to bootstrap 5.2 #3660

Closed

Conversation

gravitystorm
Copy link
Collaborator

The upgrade exposed a problem with the way we were calling the mixins, so use named arguments instead. This is probably a better approach in any case.

Also remove a background declaration that is not required.

The upgrade exposed a problem with the way we were calling the mixins,
so use named arguments instead. This is probably a better approach
in any case.

Also remove a background declaration that is not required.
@gravitystorm gravitystorm added the refactor Refactoring, or things that work but could be done better label Aug 24, 2022
@gravitystorm gravitystorm marked this pull request as draft August 24, 2022 12:44
@gravitystorm
Copy link
Collaborator Author

There's something weird going on with sass in CI, so I've converted this to a draft while I go spelunking on that.

@gravitystorm
Copy link
Collaborator Author

There's something weird going on with sass in CI, so I've converted this to a draft while I go spelunking on that.

sass/sassc-rails#174 is the only mention I've found so far, doesn't hint at any workarounds.

@gravitystorm gravitystorm added the awaiting upstream We are waiting for code from other project, like Rails or a Gem label Aug 24, 2022
@Firefishy
Copy link
Member

Firefishy commented Aug 30, 2022

sass/sassc-ruby#233 worked for me, I cannot comment if it is a pretty or the "right" solution.

@Firefishy
Copy link
Member

There are also relevant comments here: sass/sassc-ruby#220

@gravitystorm
Copy link
Collaborator Author

@Firefishy great, thanks for the links.

Since this isn't urgent, and figuring out "what to do with sass" is a much bigger and more complex situation than I expected, I'm going to close this PR for now. I'll revisit the bootstrap 5.2 upgrade in a few weeks/months and see what the wider state of play is by that point.

@gravitystorm gravitystorm deleted the bootstrap_5_2 branch October 19, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting upstream We are waiting for code from other project, like Rails or a Gem refactor Refactoring, or things that work but could be done better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants