Add profile location

[nertc]

PR adds location name info on the user profile page. Location name can be changed from "Edit Profile" page either by manual typing or auto-filling according to the home location.

One column was added to the user table to save user's location.
JS logics are responsible for handling:

1. Delete-Undelete buttons interactions
2. Nominatim calls to locate home locations country name
3. Warning logic of the location name

[tomhughes]

This seems like an awful lot of complication...

It seems to me that we have the option of either allowing the user to input freetext, or of generating something from the location with Nominatim but this tries to do both at once which just makes things very complicated and probably quite confusing.

How often does nomination actually manage to match? I don't see any indication of zoom on the reverse geocode, and you're just taking the last name, so how likely is it that will match what the user entered even if they are trying to be accurate? Are we just going to wind up telling everybody their location doesn't match?

[nertc]

@tomhughes Thank you for the comment. I agree with you about the complexity of the code, but there are several reasons for both methods.

Changing location name manually solves cases like:

1. Disputed areas - someone living in the area A may not want to show that area is part of country B and not C.
2. Several countries - someone who has citizenship of several countries may want to set his location name to something like "Georgia & Germany"
3. Choosing privacy - someone may want to explicitly mention "Tbilisi, Georgia", but someone may want to just show the country and keep other details private

Meanwhile, changing location with Nominatim autofill introduces:

1. Better UX - if user is okay with showing only home country, autofill avoids extra typing from user
2. Standardization - default value introduces default standard for user to easily perceive what kind of and what detalization of information is recommended for the field
3. Motivation to fill - when user sees a warning about the field that it doesn't match home location, it subconsciously motivates him to click the autofill button (just one easy click) and increases use of the feature

By choosing only one solution we sacrifice either functionality or better UX.

Currently, autofill suggests name of the country and warning is only shown if manually typed location doesn't contain country name. Therefore, "Germany & Georgia", "Tbilisi, Georgia", "Georgia" won't show any autofill warning if user has home location set in Georgia.

[AntonKhorev]

blocked by content security policy

[nertc]

Was updated to get information from the local call instead of directly accessing Nominatim.

[AntonKhorev]

This looks like a sentence and it's not obvious that it ends with a button I'm supposed to click to update the value:

[nertc]

Was changed with the button named "Autofill %{country}".

[AntonKhorev]

The language of %{country} is currently based on the browser settings / Accept-Language header. Is it what we want?

[AntonKhorev]

Maybe we want something like this?

"Autofill %{country}" is probably not going to look good because it's likely going to be composed of two different languages.

[AntonKhorev]

and the button can become too large

[nertc]

Thanks for suggestions. I agree with you, it seems current solution has some UI problems, but adding additional disabled input doesn't align with the UI practices we are currently using. Maybe making it more minimalistic will be better:
We can remove button and have only following logic:

If user has empty `Location Name` field when entering `Profile Edit`:
    Until user changes `Location Name` field manually:
        Autofill will automatically fill `Location Name` field on pin change
Otherwise (if user has already saved `Location Name` and, therefore, field is filled, when entering `Profile Edit`):
    If `Location Name` field value exactly matches with the country name of the pin:
        Until user changes `Location Name` field manually:
            Autofill will automatically fill `Location Name` field on pin change
    Otherwise:
        Autofill will be deactivated

[AntonKhorev]

If Location Name field value exactly matches with the country name of the pin

That requires fetching the country from Nominatim before the location changes, possibly on page load, right?

[nertc]

Yes, either on page load, or if we want to avoid an additional call on the page load, we can call Nominatim twice on the first change of the pin (one for the previous value and one for the new value, to compare them)

[nertc]

Thank you for the review. PR was updated according to the comments.

[AntonKhorev]

Wouldn't using jQuery's show / hide / toggle be simpler than manipulating classes? Although maybe not with d-none...

Actually I'm using .prop("hidden", ...) for hiding/showing buttons in this script. Probably all buttons should use the same method of hiding.

[AntonKhorev]

We probably want <title> in this svg.