Adding map note tags - part 1 - added migration script and model files #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nenad-vujicic
force-pushed
the
issue_5294_task_1
branch
from
fbcf7fc to
ea120b0
Compare
AntonKhorev
reviewed
Dec 7, 2024
Added NoteTag model class, note_tags DB table, associations between Note and NoteTag and private / foreign keys.
Added registering new factory bot for note_tag and added new unit tests to NoteTagTest for checking if key length is valid, value length is valid, key length is invalid, value length is invalid, orphaned tag is invalid and note_tags are unique.
nenad-vujicic
force-pushed
the
issue_5294_task_1
branch
from
ea120b0 to
50f6392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added migration for creating
note_tagsDB table, created model fileNoteTag.rb, updated associations withNoteclass and addednote_tagfactory and unit testsNoteTagTestsfor testing basic functionalities (key/value lengths validity, key/value lengths invalidity, orphaned tags invalidity and note-tags uniqueness).This PR is first step of adding support for map note tags described in #5294 and which fully implementation can be found here (decomposed to smaller because of simpler review).
How has this been tested?
Tested by running linters from
lint.ymlworkflow, unit tests and by manually inserting note-tags manipulations and as part of complete implementation locally.