Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color mode preference stored in db #5339

Merged

Conversation

AntonKhorev
Copy link
Collaborator

The same as #5337 but stores the preferred color scheme value in user preferences db table instead of cookies.

@gravitystorm
Copy link
Collaborator

I think the preference should have three options - auto (default), light and dark. In auto mode, either the browser color-mode should be used, or if that's not available, we should use light mode.

See #5324 (comment) for more details.

@AntonKhorev
Copy link
Collaborator Author

I also think that it should have three options. The question is do you want a larger pull request that adds three options or do you want a smaller one (you usually say you want small pull requests) that lets you disable the auto dark mode?

@gravitystorm
Copy link
Collaborator

I think if we both agree to add a new preference with 3 options, there's no need to split that into different pull requests for each option! 😄

@AntonKhorev AntonKhorev force-pushed the color-mode-preference-db branch 2 times, most recently from ed0259d to 0f595ba Compare November 27, 2024 20:48
@AntonKhorev
Copy link
Collaborator Author

Updated with dark option

@AntonKhorev AntonKhorev force-pushed the color-mode-preference-db branch from 0f595ba to 498d38e Compare November 30, 2024 23:52
@AntonKhorev AntonKhorev force-pushed the color-mode-preference-db branch from 498d38e to ef6e870 Compare December 1, 2024 00:56
@AntonKhorev AntonKhorev force-pushed the color-mode-preference-db branch from ef6e870 to 045af66 Compare December 1, 2024 01:56
@gravitystorm gravitystorm merged commit 045af66 into openstreetmap:master Dec 11, 2024
22 checks passed
@AntonKhorev AntonKhorev deleted the color-mode-preference-db branch December 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants