Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release process runs twice #958

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

project-defiant
Copy link
Contributor

@project-defiant project-defiant commented Dec 17, 2024

✨ Context

This PR refers to the opentargets/issues#3673.

🛠 What does this PR implement

There were two causes to run twice the downstream jobs on release process was

  • bug in how the if condition was evaluated - the value of the if: ${{ steps.semrelease.outputs.released }} == 'true' did not evaluate correctly
  • downstream jobs (publish to pypi and documentation) were not conditionally triggered by the output of semrelease

Additionally, as we do not use the release** branches, I changed the requirement to publish-to-testpypi to run on main branch (as a test before the actual pypi release)

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@project-defiant project-defiant changed the title Szsz fix to release process fix: release process runs twice Dec 17, 2024
@project-defiant project-defiant marked this pull request as ready for review December 17, 2024 09:22
@project-defiant project-defiant added bug Something isn't working CI labels Dec 17, 2024
@project-defiant project-defiant linked an issue Dec 17, 2024 that may be closed by this pull request
Copy link
Contributor

@ireneisdoomed ireneisdoomed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes. Just one Q about the pypy test workflow, are we publishing to Pypy and Tespypy at the same time (after the commit to main)? If so, what is the value of publishing to different repositories at the same time?

Copy link
Contributor

@ireneisdoomed ireneisdoomed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it now!
The process is:

  • allow to publish to TestPypy
  • test the package
  • allow to publish to Pypy
  • 🥳

@project-defiant project-defiant merged commit 7d42444 into dev Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI size-S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gentropy release deployment failure
3 participants