Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump pyspark version #974

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

chore: bump pyspark version #974

wants to merge 17 commits into from

Conversation

project-defiant
Copy link
Contributor

@project-defiant project-defiant commented Jan 16, 2025

✨ Context

This PR closes #3189 and links to opentargets/orchestration#94

🛠 What does this PR implement

This PR allows pyspark>=3.5.0, <3.6 along with newest hail version, that supports it.

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

Copy link
Contributor

@ireneisdoomed ireneisdoomed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
2 questions:

  1. Should we also give support to pyspark versions lower than 3.5? Afaik, there is nothing in the API that is not compatible. I know we have custom code to compare dataframes, something that Pyspark 3.5 supports
  2. We need to update the Dataproc version too. Should we make a pipeline run to test nothing breaks?

@project-defiant
Copy link
Contributor Author

Thank you! 2 questions:

  1. Should we also give support to pyspark versions lower than 3.5? Afaik, there is nothing in the API that is not compatible. I know we have custom code to compare dataframes, something that Pyspark 3.5 supports
  2. We need to update the Dataproc version too. Should we make a pipeline run to test nothing breaks?

These are very nice points!

  1. I am aftraid, that poetry will not allow us to supoport more pyspark versions, latest hail requires version between 3.5 to 3.6, otherwise we could do it.
  2. Yes I am planning to do that, just right after I finish the harmonisation :). Let's wait for this check before we merge.

@github-actions github-actions bot added the Step label Jan 21, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation size-XL and removed size-M labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Dataproc and PySpark in Genetics
3 participants