-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump pyspark version #974
Open
project-defiant
wants to merge
17
commits into
dev
Choose a base branch
from
pyspark-bump
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4,231
−6,609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-defiant
force-pushed
the
pyspark-bump
branch
from
January 17, 2025 10:30
371441b
to
630c0c9
Compare
project-defiant
requested review from
ireneisdoomed
and removed request for
ireneisdoomed
January 17, 2025 10:36
ireneisdoomed
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
2 questions:
- Should we also give support to pyspark versions lower than 3.5? Afaik, there is nothing in the API that is not compatible. I know we have custom code to compare dataframes, something that Pyspark 3.5 supports
- We need to update the Dataproc version too. Should we make a pipeline run to test nothing breaks?
These are very nice points!
|
This reverts commit 18c66b1.
github-actions
bot
added
documentation
Improvements or additions to documentation
size-XL
and removed
size-M
labels
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Chore
Dataset
Datasource
documentation
Improvements or additions to documentation
Method
size-XL
Step
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
This PR closes #3189 and links to opentargets/orchestration#94
🛠 What does this PR implement
This PR allows pyspark>=3.5.0, <3.6 along with newest hail version, that supports it.
🙈 Missing
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?