refactor: remove variant vsariable from CS profile request

opentargets · Dec 11, 2024 · 0beab51 · 0beab51
1 parent 1b4c808
commit 0beab51
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 30 deletions.
diff --git a/apps/platform/src/pages/CredibleSetPage/Profile.tsx b/apps/platform/src/pages/CredibleSetPage/Profile.tsx
@@ -35,7 +35,7 @@ function Profile({ studyLocusId, variantId, referenceAllele, alternateAllele }:
   );
 
   const CREDIBLE_SET_PROFILE_QUERY = gql`
-    query CredibleSetProfileQuery($studyLocusId: String!, $variantIds: [String!]!) {
+    query CredibleSetProfileQuery($studyLocusId: String!) {
       credibleSet(studyLocusId: $studyLocusId) {
         studyLocusId
         ...CredibleSetProfileHeaderFragment
@@ -50,7 +50,7 @@ function Profile({ studyLocusId, variantId, referenceAllele, alternateAllele }:
     <PlatformApiProvider
       entity={CREDIBLE_SET}
       query={CREDIBLE_SET_PROFILE_QUERY}
-      variables={{ studyLocusId: studyLocusId, variantIds: [variantId] }}
+      variables={{ studyLocusId: studyLocusId }}
       client={client}
     >
       <ProfileHeader />

diff --git a/apps/platform/src/pages/CredibleSetPage/ProfileHeader.gql b/apps/platform/src/pages/CredibleSetPage/ProfileHeader.gql
@@ -5,7 +5,7 @@ fragment CredibleSetProfileHeaderFragment on credibleSet {
   standardError
   effectAlleleFrequencyFromSource
   qualityControls
-  locus(variantIds: $variantIds) {
+  locus(page: { size: 1, index: 0 }) {
     count
     rows {
       posteriorProbability

diff --git a/apps/platform/src/pages/CredibleSetPage/ProfileHeader.tsx b/apps/platform/src/pages/CredibleSetPage/ProfileHeader.tsx
@@ -25,14 +25,15 @@ function ProfileHeader() {
   if (error) return null;
 
   const credibleSet = data?.credibleSet;
+  const leadVariant = credibleSet?.locus?.rows?.[0] || {};
+  const beta = leadVariant.beta ?? credibleSet?.beta;
+  const standardError = leadVariant.standardError ?? credibleSet?.standardError;
   const study = credibleSet?.study;
   const target = study?.target;
-  const leadVariant = credibleSet?.locus.rows[0];
-  const beta = leadVariant?.beta ?? credibleSet?.beta;
-  const standardError = leadVariant?.standardError ?? credibleSet?.standardError;
+
   const { pValueMantissa, pValueExponent } =
     typeof leadVariant?.pValueMantissa === "number" &&
-      typeof leadVariant?.pValueExponent === "number"
+    typeof leadVariant?.pValueExponent === "number"
       ? leadVariant
       : credibleSet ?? {};
 
@@ -169,24 +170,26 @@ function ProfileHeader() {
         >
           {credibleSet?.purityMinR2?.toPrecision(3)}
         </Field>
-        {credibleSet?.qualityControls?.length > 0 &&
+        {credibleSet?.qualityControls?.length > 0 && (
           <Box>
             <DetailPopover title="QC warnings">
-              <ul style={{
-                display: "flex",
-                flexDirection: "column",
-                gap: "0.25rem",
-                padding: 0,
-                margin: "0 0 0 1rem"
-              }}>
+              <ul
+                style={{
+                  display: "flex",
+                  flexDirection: "column",
+                  gap: "0.25rem",
+                  padding: 0,
+                  margin: "0 0 0 1rem",
+                }}
+              >
                 {credibleSet.qualityControls.map(warning => (
                   <li key={warning}>{warning}</li>
                 ))}
               </ul>
             </DetailPopover>
           </Box>
-        }
-      </Box >
+        )}
+      </Box>
 
       <Box>
         <Typography variant="subtitle1" mt={0}>
@@ -260,25 +263,26 @@ function ProfileHeader() {
           {study?.analysisFlags?.join(", ")}
         </Field>
         <Field loading={loading} title="Summary statistics">
-          {!study?.hasSumstats
-            ? "Not Available"
-            : study?.sumstatQCValues
-              ? <DetailPopover title="Available">
-                <SummaryStatsTable sumstatQCValues={study.sumstatQCValues} />
-              </DetailPopover>
-              : "Available"
-          }
+          {!study?.hasSumstats ? (
+            "Not Available"
+          ) : study?.sumstatQCValues ? (
+            <DetailPopover title="Available">
+              <SummaryStatsTable sumstatQCValues={study.sumstatQCValues} />
+            </DetailPopover>
+          ) : (
+            "Available"
+          )}
         </Field>
-        {study?.nSamples &&
+        {study?.nSamples && (
           <Field loading={loading} title="Sample size">
             <DisplaySampleSize
               nSamples={study.nSamples}
               cohorts={study?.cohorts}
               initialSampleSize={study?.initialSampleSize}
             />
           </Field>
-        }
-        {study?.ldPopulationStructure?.length > 0 &&
+        )}
+        {study?.ldPopulationStructure?.length > 0 && (
           <Box display="flex" sx={{ gap: 1 }}>
             {study.ldPopulationStructure.map(({ ldPopulation, relativeSampleSize }) => (
               <LabelChip
@@ -289,9 +293,9 @@ function ProfileHeader() {
               />
             ))}
           </Box>
-        }
+        )}
       </Box>
-    </BaseProfileHeader >
+    </BaseProfileHeader>
   );
 }