Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(site): Optimize site documentation typesetting #2688

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

dufu1991
Copy link
Contributor

@dufu1991 dufu1991 commented Dec 21, 2024

… English punctuation, and avoid excessive use of spaces for all Chinese text and comments within the site.

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Introduced new components: Dropdown, Notify, and ActionMenu.
    • Added support for theme configuration transformations and TypeScript type declarations.
    • Expanded theme customization options with new properties in the ThemeData interface and the changeTheme method.
  • Bug Fixes

    • Resolved issues in components like Tabs, Numeric counter, Grid table, DatePicker, and Select.
    • Fixed popup positioning issues in micro-frontend environments.
  • Documentation

    • Enhanced clarity and usability in various markdown documents, including installation instructions, theme configuration, and validation rules.
    • Updated changelog to reflect recent updates and improvements.

… English punctuation, and avoid excessive use of spaces for all Chinese text and comments within the site.
Copy link

coderabbitai bot commented Dec 21, 2024

Walkthrough

The pull request focuses on updating documentation across multiple markdown files in the TinyVue project's demo and web documentation directory. The changes primarily involve improving readability, formatting, and clarity of explanations related to theme configuration, component imports, installation instructions, and changelog details. The modifications include adding consistent spacing, refining text descriptions, and updating code examples to enhance understanding for developers using the TinyVue framework.

Changes

File Change Summary
aui-adapter.md Updated SaaS theme integration details, refined multi-mode component support explanation
changelog-en.md Updated version changelogs with new components, features, and bug fixes
changelog.md Updated version changelogs with component enhancements and bug fixes
develop-demo.md Minor grammatical corrections and spacing adjustments
faq-en.md Updated popup element issue explanation in micro front-end context
faq.md Refined popup positioning logic for micro-frontend scenarios
form-valid.md Improved readability of validation rule messages
import-components.md Enhanced formatting and clarified dependency management
installation.md Added consistent spacing in version descriptions
theme-en.md Comprehensive update on theme configuration, customization, and usage
theme.md Formatting improvements for theme documentation

Suggested labels

documentation

Suggested reviewers

  • zzcr

Poem

🐰 Docs dancing with grace,
Spaces aligned, a rabbit's embrace
Clarity springs, like code so bright
TinyVue's wisdom takes flight!
Hop, hop, documentation delight! 🌈


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the enhancement New feature or request label Dec 21, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
examples/sites/demos/pc/webdoc/import-components.md (1)

Line range hint 1-300: Consider adding a table of contents.

The document is well-structured but quite long. Consider adding a table of contents at the beginning to help users quickly navigate to different import methods.

Example TOC structure:

## 目录

- [自动导入(推荐)](#自动导入推荐)
- [多组件引入](#多组件引入)
- [vite 工程多组件引入按需加载和打包配置方法](#vite-工程多组件引入按需加载和打包配置方法)
- [单组件引入](#单组件引入)
- [完整引入(不推荐)](#完整引入不推荐)
examples/sites/demos/pc/webdoc/changelog-en.md (1)

158-158: Minor grammar improvement needed.

The breaking change is well-documented, but there's a minor grammatical issue. Consider removing the comma before "because" as it's an essential clause:

-Remove the `rich-text` component, because the third-party plug-in `quill` introduced by the component is an overdue high-risk dependency
+Remove the `rich-text` component because the third-party plug-in `quill` introduced by the component is an overdue high-risk dependency
🧰 Tools
🪛 LanguageTool

[formatting] ~158-~158: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...nges - Remove the rich-text component, because the third-party plug-in quill introdu...

(COMMA_BEFORE_BECAUSE)

examples/sites/demos/pc/webdoc/theme-en.md (2)

104-104: Fix bare URL in Chinese text section.

The URL should be properly formatted as a markdown link for better readability and maintainability.

-旧主题不能 100% 还原历史版本的所有细节,如果用户升级后有较大的影响,可以跟我们反馈。也可以回退使用<code> @opentiny/vue@3.18.0 </code> 版本,我们将继续维护一段时间。
+旧主题不能 100% 还原历史版本的所有细节,如果用户升级后有较大的影响,可以[跟我们反馈](https://github.com/opentiny/tiny-vue/issues/new/choose)。也可以回退使用<code> @opentiny/vue@3.18.0 </code> 版本,我们将继续维护一段时间。

Line range hint 205-205: Inconsistent language usage in documentation.

The documentation switches between English and Chinese without clear separation, which may confuse readers. Consider maintaining consistent language usage within each section.

Consider:

  1. Separating the content into distinct English and Chinese sections
  2. Using language tags to clearly indicate the language of each section
  3. Ensuring each section is complete in its respective language

Also applies to: 538-538

examples/sites/demos/pc/webdoc/changelog.md (1)

104-104: Format bare URLs as markdown links

There are several bare URLs in the changelog that should be properly formatted as markdown links for better readability and consistency.

Apply this formatting to the URLs:

-https://github.com/opentiny/tiny-vue/pull/2588
+[#2588](https://github.com/opentiny/tiny-vue/pull/2588)

Also applies to: 205-205, 538-538

🧰 Tools
🪛 Markdownlint (0.37.0)

104-104: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d0429d and 0d99213.

📒 Files selected for processing (11)
  • examples/sites/demos/pc/webdoc/aui-adapter.md (4 hunks)
  • examples/sites/demos/pc/webdoc/changelog-en.md (1 hunks)
  • examples/sites/demos/pc/webdoc/changelog.md (4 hunks)
  • examples/sites/demos/pc/webdoc/develop-demo.md (2 hunks)
  • examples/sites/demos/pc/webdoc/faq-en.md (1 hunks)
  • examples/sites/demos/pc/webdoc/faq.md (1 hunks)
  • examples/sites/demos/pc/webdoc/form-valid.md (6 hunks)
  • examples/sites/demos/pc/webdoc/import-components.md (2 hunks)
  • examples/sites/demos/pc/webdoc/installation.md (3 hunks)
  • examples/sites/demos/pc/webdoc/theme-en.md (1 hunks)
  • examples/sites/demos/pc/webdoc/theme.md (7 hunks)
✅ Files skipped from review due to trivial changes (5)
  • examples/sites/demos/pc/webdoc/develop-demo.md
  • examples/sites/demos/pc/webdoc/form-valid.md
  • examples/sites/demos/pc/webdoc/faq-en.md
  • examples/sites/demos/pc/webdoc/installation.md
  • examples/sites/demos/pc/webdoc/theme.md
🧰 Additional context used
🪛 Markdownlint (0.37.0)
examples/sites/demos/pc/webdoc/changelog.md

104-104: null
Bare URL used

(MD034, no-bare-urls)


205-205: null
Bare URL used

(MD034, no-bare-urls)


538-538: null
Bare URL used

(MD034, no-bare-urls)

🪛 LanguageTool
examples/sites/demos/pc/webdoc/changelog-en.md

[formatting] ~158-~158: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...nges - Remove the rich-text component, because the third-party plug-in quill introdu...

(COMMA_BEFORE_BECAUSE)

examples/sites/demos/pc/webdoc/aui-adapter.md

[uncategorized] ~27-~27: 数词与名词之间一般应存在量词,可能缺少量词。
Context: ...aaS  主题可以按照下述文档,进行打包配置更改: #### 方法一 方案一需要额外安装以下依赖: - @opentiny/vue-theme-saas` ...

(wa5)

🔇 Additional comments (5)
examples/sites/demos/pc/webdoc/import-components.md (2)

137-137: LGTM! Improved Chinese text readability.

The added spaces around "Tiny" and version number "3.17.0" follow proper Chinese typography practices and enhance readability.


200-200: LGTM! Improved comment readability.

The added space before the parentheses in the configuration comment improves readability while maintaining clarity of the options.

examples/sites/demos/pc/webdoc/faq.md (1)

15-17: LGTM! Clear and well-documented solution.

The comment improvement enhances readability while accurately explaining how to access the main application's window in a child application context.

examples/sites/demos/pc/webdoc/aui-adapter.md (2)

71-74: LGTM! Clear configuration example.

The template example clearly demonstrates how to inject the SaaS design configuration using the ConfigProvider component.


Line range hint 177-191: LGTM! Well-structured mode switching example.

The example effectively demonstrates different button styles across PC and multi-end modes, providing a clear reference for implementing mode-specific UI variations.

@zzcr zzcr merged commit 647561d into opentiny:dev Dec 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants