Fix submission namespace output when including dashes #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new provider or module has been submitted which included a `-` within the namespace of the Git repository, only the last portion of the user or organization was picked. See opentofu#125 as an example where `metal-stack-cloud/terraform-provider-metal` resulted in a errornous repository url of `https://github.com/cloud/terraform-provider-metal`. Signed-off-by: Valentin Knabel <dev@vknabel.com>
vknabel
force-pushed
the
fix/organizations-might-contain-dashes
branch
from
c44adbd to
79beb83
Compare
ghost
requested review from
ghost
reviewed
Dec 21, 2023
|
@vknabel thank you for reporting this, it looks to me as if that regexp you changed could do with a little more attention from our side. It may need more than this change, but we'll try to sort it out as quickly as possible since this seems to be a blocker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new provider or module has been submitted which included a
-within the namespace of the Git repository, only the last portion of the user or organization was picked.See #125 as an example where
metal-stack-cloud/terraform-provider-metalresulted in a errornous repository url ofhttps://github.com/cloud/terraform-provider-metal.