Support Floating Vehicle Bunching #1333
Open
+85
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
| <CardFooter> | ||
| <span> | ||
| <FormattedMessage | ||
| id="components.NearbyView.additionalVehicles" |
There was a problem hiding this comment.
Was this layout more advantageous than placing this text underneath the distance label (see illustration)?
binh-dam-ibigroup
approved these changes
Jan 14, 2025
| display: block; | ||
| } | ||
|
|
||
| &::before { |
There was a problem hiding this comment.
Is this for the margin between the footer and the body of the card, and can it be done using margin-top of CardFooter itself instead?
| @@ -119,6 +120,18 @@ const Vehicle = ({ | |||
| )} | |||
| {fromToSlot} | |||
| </CardBody> | |||
| {vehicle.additionalCount > 0 && ( | |||
| <CardFooter> | |||
| <span> | |||
There was a problem hiding this comment.
Is the span needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
PR Checklist: